Critical Description
In ThreadingSuite we have things like:
test(...) {
...
val threads = (1 to 5).map { i =>
new Thread() {
override def run() {
assert(sc.getLocalProperty("test") === "parent")
sc.setLocalProperty("test", i.toString)
assert(sc.getLocalProperty("test") === i.toString)
sem.release()
}
}
}
...
}
If the asserts in the run block fail, they don't actually fail the test! This could mask real bugs.
