Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9992

Add support for grouping with PointFIelds

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.6
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Followup task of SOLR-8396

      1. SOLR-9992.patch
        13 kB
        Cao Manh Dat

        Issue Links

          Activity

          Hide
          caomanhdat Cao Manh Dat added a comment -

          Tomás Fernández Löbbe Found that TestGroupingSearch only failed with PointFields with this assertion

              // test that grouping works with highlighting
              assertJQ(req("fq",filt,  "q","{!func}"+f2, "group","true", "group.field",f, "fl","id"
                           ,"hl","true", "hl.fl",f)
                ,"/grouped/"+f+"/matches==10"
                ,"/highlighting=={'_ORDERED_':'', '8':{  },'3':{},'4':{},'1':{},'2':{}}"
              );
          

          Wondering why we even need highlighting on numeric field?

          Show
          caomanhdat Cao Manh Dat added a comment - Tomás Fernández Löbbe Found that TestGroupingSearch only failed with PointFields with this assertion // test that grouping works with highlighting assertJQ(req( "fq" ,filt, "q" , "{!func}" +f2, "group" , " true " , "group.field" ,f, "fl" , "id" , "hl" , " true " , "hl.fl" ,f) , "/grouped/" +f+ "/matches==10" , "/highlighting=={'_ORDERED_':'', '8':{ },'3':{},'4':{},'1':{},'2':{}}" ); Wondering why we even need highlighting on numeric field?
          Hide
          dsmiley David Smiley added a comment -

          No highlighter supports highlighting numeric fields. Notice that there are no snippets in the result. It's kind of a lame assertion in this test.... it'd be more useful to highlight a grouped string.

          It would be useful if the highlighters could highlight a numeric field. Consider the user experience where there are a bunch of fields to highlight, some of which happen to be numeric and the user's query is a number that matched one of those fields.

          Show
          dsmiley David Smiley added a comment - No highlighter supports highlighting numeric fields. Notice that there are no snippets in the result. It's kind of a lame assertion in this test.... it'd be more useful to highlight a grouped string. It would be useful if the highlighters could highlight a numeric field. Consider the user experience where there are a bunch of fields to highlight, some of which happen to be numeric and the user's query is a number that matched one of those fields.
          Hide
          caomanhdat Cao Manh Dat added a comment - - edited

          It would be useful if the highlighters could highlight a numeric field. Consider the user experience where there are a bunch of fields to highlight, some of which happen to be numeric and the user's query is a number that matched one of those fields.

          That make sense, we can create another ticket to solve this problem. In case of this ticket I think it's safe to remove this test.

          Show
          caomanhdat Cao Manh Dat added a comment - - edited It would be useful if the highlighters could highlight a numeric field. Consider the user experience where there are a bunch of fields to highlight, some of which happen to be numeric and the user's query is a number that matched one of those fields. That make sense, we can create another ticket to solve this problem. In case of this ticket I think it's safe to remove this test.
          Hide
          tomasflobbe Tomás Fernández Löbbe added a comment -

          Cao Manh Dat, It's possible that we just need to add/update a test. As I was working on SOLR-8396 I couldn't dive into all features, so I just created Jiras like this for tasks that were not essential at the time.

          Show
          tomasflobbe Tomás Fernández Löbbe added a comment - Cao Manh Dat , It's possible that we just need to add/update a test. As I was working on SOLR-8396 I couldn't dive into all features, so I just created Jiras like this for tasks that were not essential at the time.
          Hide
          caomanhdat Cao Manh Dat added a comment -

          A patch for this ticket. test-core passed on both case ( PointFields and TrieFields )

          Show
          caomanhdat Cao Manh Dat added a comment - A patch for this ticket. test-core passed on both case ( PointFields and TrieFields )
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 21adce4a2fa6d9a207cd8abed11ba050ff57c933 in lucene-solr's branch refs/heads/master from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21adce4 ]

          SOLR-9992: Add support for grouping with PointFIelds

          Show
          jira-bot ASF subversion and git services added a comment - Commit 21adce4a2fa6d9a207cd8abed11ba050ff57c933 in lucene-solr's branch refs/heads/master from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=21adce4 ] SOLR-9992 : Add support for grouping with PointFIelds
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c03e34227f8029c332a7fbebb4936529431f5d40 in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c03e342 ]

          SOLR-9992: Add support for grouping with PointFIelds

          Show
          jira-bot ASF subversion and git services added a comment - Commit c03e34227f8029c332a7fbebb4936529431f5d40 in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c03e342 ] SOLR-9992 : Add support for grouping with PointFIelds
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fb296fd5fc91faeba1b1ab7072d40e71eec17fcf in lucene-solr's branch refs/heads/master from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fb296fd ]

          SOLR-9992: Update changes.txt

          Show
          jira-bot ASF subversion and git services added a comment - Commit fb296fd5fc91faeba1b1ab7072d40e71eec17fcf in lucene-solr's branch refs/heads/master from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fb296fd ] SOLR-9992 : Update changes.txt
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 336a6192a6999efe45ed5a58f1d3989e52009a99 in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=336a619 ]

          SOLR-9992: Update CHANGES.txt

          Show
          jira-bot ASF subversion and git services added a comment - Commit 336a6192a6999efe45ed5a58f1d3989e52009a99 in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=336a619 ] SOLR-9992 : Update CHANGES.txt

            People

            • Assignee:
              caomanhdat Cao Manh Dat
              Reporter:
              tomasflobbe Tomás Fernández Löbbe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development