[SOLR-9988] Add method toInternalByteRef to FieldType and possibly deprecate toInternal()

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Labels: numeric-tries-to-points
• Assignee: Unassigned
• Reporter: Tomas Eduardo Fernandez Lobbe
• Created: 19/Jan/17 01:46
• Updated: 08/Jun/19 15:33

Description

Point FieldTypes can't be Strings in it's "internal representation", so calling ft.toInternal(...) is not supported. For those fields we use toInternalByteRef(...) that does the same thing but returns a BytesRef instance instead of a String. In many cases, the consumer of toInternal(...) actually needs (or can optionally use) a BytesRef and we end up creating one from the String. It would be better to have toInternal() return a BytesRef instance, it can be easily converted to a String if needed

Issue Links

• is related to: SOLR-10847 TermsComponent doesn't work with Points fields - confusing errors when using terms.list
• relates to: SOLR-8396 Add support for PointFields in Solr