Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      An Evaluator does not know about the Context object which limits use-cases. For example, the use-case given by Gregg in solr-user – http://markmail.org/thread/pu3z27lreefbbkin

      We can add the evaluate method and pass in the Context object. It is a non back-compatible change but since the Evaluator is marked as experimental and it's API has never been documented on the wiki, it should be fine.

      We should also rename it to Function to be consistent with the dataimporter.functions namespace it is used with.

      1. SOLR-996.patch
        15 kB
        Shalin Shekhar Mangar
      2. SOLR-996.patch
        13 kB
        Shalin Shekhar Mangar
      3. SOLR-996.patch
        15 kB
        Noble Paul

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Patch in sync with trunk and minor javadoc updates.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Patch in sync with trunk and minor javadoc updates.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        The previous patch had missed a few changes. I'll commit this shortly.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - The previous patch had missed a few changes. I'll commit this shortly.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Committed revision 745734.

        Thanks Noble!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 745734. Thanks Noble!
        Hide
        gsingers Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development