Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9931

hll omits value in distributed mode when no values in field

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: Facet Module
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Given a non-empty bucket, but hll of a field with no values for that bucket domain

      • In non-distributed mode, hll returns 0
      • In distributed mode, the key+value is omitted entirely

      We should make these consistent.
      In this case, what makes the most sense is to return 0 for both.

      1. SOLR-9931.patch
        4 kB
        Yonik Seeley
      2. SOLR-9931.patch
        2 kB
        Yonik Seeley

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Here's a simple test that currently fails.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Here's a simple test that currently fails.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        OK, here's a patch that returns 0 for both distrib and non-distrib hll for a non-empty bucket with no values in the field. Basically, at the shard level, it returns 0 for that case, and the distributed merger checks for a number (as opposed to just checking for the serialized HLL bytes)

        Show
        yseeley@gmail.com Yonik Seeley added a comment - OK, here's a patch that returns 0 for both distrib and non-distrib hll for a non-empty bucket with no values in the field. Basically, at the shard level, it returns 0 for that case, and the distributed merger checks for a number (as opposed to just checking for the serialized HLL bytes)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a810fb3234ec461e23c76533fbfcc523d4c46faa in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a810fb3 ]

        SOLR-9931: return 0 for hll on field with no values in bucket

        Show
        jira-bot ASF subversion and git services added a comment - Commit a810fb3234ec461e23c76533fbfcc523d4c46faa in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a810fb3 ] SOLR-9931 : return 0 for hll on field with no values in bucket
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dd06a0b9041eb42dd308a51e6337bbbe4b3057fc in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd06a0b ]

        SOLR-9931: return 0 for hll on field with no values in bucket

        Show
        jira-bot ASF subversion and git services added a comment - Commit dd06a0b9041eb42dd308a51e6337bbbe4b3057fc in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd06a0b ] SOLR-9931 : return 0 for hll on field with no values in bucket

          People

          • Assignee:
            yseeley@gmail.com Yonik Seeley
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development