Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9912

SimpleFacets - support facet.excludeTerms parameter

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      This ticket is for supporting a new facet.excludeTerms parameter for removing specific terms from the facet counts, without having to exclude the terms from the index itself.

      1. SOLR-9912.patch
        9 kB
        Jonny Marks
      2. SOLR-9912.patch
        12 kB
        Jonny Marks
      3. SOLR-9912.patch
        12 kB
        Jonny Marks
      4. SOLR-9912.patch
        17 kB
        Jonny Marks

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          Jonny and I have been collaborating on this. I think it's good to go. Comments, questions, etc. welcome as usual. Hoping to commit middle/end of next week or so. Thank you.

          Show
          cpoerschke Christine Poerschke added a comment - Jonny and I have been collaborating on this. I think it's good to go. Comments, questions, etc. welcome as usual. Hoping to commit middle/end of next week or so. Thank you.
          Hide
          dsmiley David Smiley added a comment -

          This looks good but the patch is incomplete; it doesn't contain SubstringBytesRefFilter

          Show
          dsmiley David Smiley added a comment - This looks good but the patch is incomplete; it doesn't contain SubstringBytesRefFilter
          Hide
          jm100 Jonny Marks added a comment -

          Updated patch to use Predicate instead of BytesRefFilter

          Show
          jm100 Jonny Marks added a comment - Updated patch to use Predicate instead of BytesRefFilter
          Hide
          jm100 Jonny Marks added a comment -

          Updating patch after SimpleFacets.contains removed in subtask

          Show
          jm100 Jonny Marks added a comment - Updating patch after SimpleFacets.contains removed in subtask
          Hide
          dsmiley David Smiley added a comment -

          Looking good. I like the use of Predicate.and.

          Might you make ExcludeBytesRefFilter an anonymous inner class instead a top level public class? It's really small and it's yet another file / thing to name.

          Show
          dsmiley David Smiley added a comment - Looking good. I like the use of Predicate.and . Might you make ExcludeBytesRefFilter an anonymous inner class instead a top level public class? It's really small and it's yet another file / thing to name.
          Hide
          jm100 Jonny Marks added a comment -

          Moved ExcludeBytesRefFilter to anonymous inner class

          Show
          jm100 Jonny Marks added a comment - Moved ExcludeBytesRefFilter to anonymous inner class
          Hide
          dsmiley David Smiley added a comment -

          Nicely concise +1 to commit Christine Poerschke

          Show
          dsmiley David Smiley added a comment - Nicely concise +1 to commit Christine Poerschke
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0b817e6e495c40496b7cedc6f06060e43e5e2afc in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b817e6 ]

          SOLR-9912: Add facet.excludeTerms parameter support. (Jonny Marks, David Smiley, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0b817e6e495c40496b7cedc6f06060e43e5e2afc in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0b817e6 ] SOLR-9912 : Add facet.excludeTerms parameter support. (Jonny Marks, David Smiley, Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f9194854d6c5c46e24a041dc8929d0970b16d542 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f919485 ]

          SOLR-9912: Add facet.excludeTerms parameter support. (Jonny Marks, David Smiley, Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit f9194854d6c5c46e24a041dc8929d0970b16d542 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f919485 ] SOLR-9912 : Add facet.excludeTerms parameter support. (Jonny Marks, David Smiley, Christine Poerschke)
          Hide
          cpoerschke Christine Poerschke added a comment -

          Thanks Jonny and David!

          (PS: I will add the new facet.excludeTerms parameter to https://cwiki.apache.org/confluence/display/solr/Faceting in the Solr Reference Guide nearer to the 6.5 release time.)

          Show
          cpoerschke Christine Poerschke added a comment - Thanks Jonny and David! (PS: I will add the new facet.excludeTerms parameter to https://cwiki.apache.org/confluence/display/solr/Faceting in the Solr Reference Guide nearer to the 6.5 release time.)
          Hide
          mdrob Mike Drob added a comment -

          minor nit: this commit and SOLR-9914 added two unsued imports to SimpleFacets.java that make my editor complain at me when it didn't before.

          Show
          mdrob Mike Drob added a comment - minor nit: this commit and SOLR-9914 added two unsued imports to SimpleFacets.java that make my editor complain at me when it didn't before.
          Hide
          elyograg Shawn Heisey added a comment -

          Hmm. The precommit target seems to NOT catch unused imports. I think it should, since they have been changed to ERROR in the eclipse integration.

          Show
          elyograg Shawn Heisey added a comment - Hmm. The precommit target seems to NOT catch unused imports. I think it should, since they have been changed to ERROR in the eclipse integration.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d89ffe23f1bb24bbf8882d11cae8444b37af26f1 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d89ffe2 ]

          SOLR-9912: Remove unused imports.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d89ffe23f1bb24bbf8882d11cae8444b37af26f1 in lucene-solr's branch refs/heads/branch_6x from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d89ffe2 ] SOLR-9912 : Remove unused imports.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 117aea93677382f3c8f60912e673f87a67db3002 in lucene-solr's branch refs/heads/master from Adrien Grand
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=117aea9 ]

          SOLR-9912: Remove unused imports.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 117aea93677382f3c8f60912e673f87a67db3002 in lucene-solr's branch refs/heads/master from Adrien Grand [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=117aea9 ] SOLR-9912 : Remove unused imports.

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              jm100 Jonny Marks
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development