Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9886

Add ability to turn off/on caches

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      There is no elegant way to turn off caches (filterCache, queryResultCache etc) from the solrconfig. When I tried setting size and initialSize to zero, it resulted in caches of size 2. Here is the code that overrides setting zero sized cache.

      https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/search/FastLRUCache.java#L61-L73

      Only way to disable cache right now is by removing cache configs from the solrConfig, but we can simply provide an attribute to disable cache, so that we can override it using a system property.

      1. EnableDisableCacheAttribute.patch
        1 kB
        Pushkar Raste
      2. SOLR-9886.patch
        8 kB
        Pushkar Raste
      3. SOLR-9886.patch
        3 kB
        Noble Paul

        Issue Links

          Activity

          Hide
          praste Pushkar Raste added a comment -

          Check attached patch. I think we may to make changes to EditableSolrConfigAttributes.json as well. I don't understand mapping between the attribute names and associated numbers.

          Show
          praste Pushkar Raste added a comment - Check attached patch. I think we may to make changes to EditableSolrConfigAttributes.json as well. I don't understand mapping between the attribute names and associated numbers.
          Hide
          noble.paul Noble Paul added a comment - - edited

          added the attributes to EditableSolrConfigAttributes.json. Test cases are missing though

          Show
          noble.paul Noble Paul added a comment - - edited added the attributes to EditableSolrConfigAttributes.json . Test cases are missing though
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user praste opened a pull request:

          https://github.com/apache/lucene-solr/pull/132

          SOLR-9886

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/praste/lucene-solr CacheConfig

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/132.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #132


          commit c5363f6dabb0a36cc41f174023eafdd443ed106f
          Author: Pushkar Raste <praste@bloomberg.net>
          Date: 2016-12-23T16:41:28Z

          Allow enable/disable cache

          commit b8daed32047475d0eee330374d8d4ed5f2820897
          Author: Pushkar Raste <praste@bloomberg.net>
          Date: 2016-12-29T18:20:56Z

          Merge branch 'master' of https://github.com/apache/lucene-solr into CacheConfig

          commit e394b405b9e6fb0024c4b3a8747ec500dd5ba3d4
          Author: Pushkar Raste <praste@bloomberg.net>
          Date: 2016-12-29T22:46:42Z

          Test case, bug fix, updated EdittableCofing.json

          commit 59484c080fc3e3e97bb5a443588c409e381e1340
          Author: Pushkar Raste <praste@bloomberg.net>
          Date: 2016-12-29T22:47:37Z

          Adding missing files


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user praste opened a pull request: https://github.com/apache/lucene-solr/pull/132 SOLR-9886 You can merge this pull request into a Git repository by running: $ git pull https://github.com/praste/lucene-solr CacheConfig Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #132 commit c5363f6dabb0a36cc41f174023eafdd443ed106f Author: Pushkar Raste <praste@bloomberg.net> Date: 2016-12-23T16:41:28Z Allow enable/disable cache commit b8daed32047475d0eee330374d8d4ed5f2820897 Author: Pushkar Raste <praste@bloomberg.net> Date: 2016-12-29T18:20:56Z Merge branch 'master' of https://github.com/apache/lucene-solr into CacheConfig commit e394b405b9e6fb0024c4b3a8747ec500dd5ba3d4 Author: Pushkar Raste <praste@bloomberg.net> Date: 2016-12-29T22:46:42Z Test case, bug fix, updated EdittableCofing.json commit 59484c080fc3e3e97bb5a443588c409e381e1340 Author: Pushkar Raste <praste@bloomberg.net> Date: 2016-12-29T22:47:37Z Adding missing files
          Hide
          praste Pushkar Raste added a comment -

          Updated patch with a test.

          Show
          praste Pushkar Raste added a comment - Updated patch with a test.
          Hide
          praste Pushkar Raste added a comment -

          Noble Paul My only concern adding legend to EditableSolrConfigAttributes.json is, if we ever parse this file using a JSON parser, we will have to move legend to some other place.

          Show
          praste Pushkar Raste added a comment - Noble Paul My only concern adding legend to EditableSolrConfigAttributes.json is, if we ever parse this file using a JSON parser, we will have to move legend to some other place.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2048b82443db548f76d584f9a95b5628c407edde in lucene-solr's branch refs/heads/master from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2048b82 ]

          • SOLR-9886: Add a 'enable' flag to caches to enable/disable them
          Show
          jira-bot ASF subversion and git services added a comment - Commit 2048b82443db548f76d584f9a95b5628c407edde in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2048b82 ] SOLR-9886 : Add a 'enable' flag to caches to enable/disable them
          Hide
          noble.paul Noble Paul added a comment -

          It should be OK

          Show
          noble.paul Noble Paul added a comment - It should be OK
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 39502a09eecbb52bf26bd52a4104ba59bca3900b in lucene-solr's branch refs/heads/branch_6x from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=39502a0 ]

          • SOLR-9886: Add a 'enable' flag to caches to enable/disable them
          Show
          jira-bot ASF subversion and git services added a comment - Commit 39502a09eecbb52bf26bd52a4104ba59bca3900b in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=39502a0 ] SOLR-9886 : Add a 'enable' flag to caches to enable/disable them

            People

            • Assignee:
              noble.paul Noble Paul
              Reporter:
              praste Pushkar Raste
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development