Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9557

Every implicit requesthandler should have a default useParams

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      If a user needs to set any request parameters on an implicitly defined requesthandler , he has to define an <initParams> section in solrconfig.xml. We should define a default paramset with all implicit handlers
      example : the /update/json/docs can have a default useParams="_UPDATE_JSON_DOCS"

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        +1 to the idea.

        Paramsets are preferable to initParams because initParams are required to be present during initialization and therefore, a core reload is necessary when modifying them (is this documented in example solrconfigs and reference guide). But why only on implicit request handlers? Why not have this convention over all request handlers?

        Also, this isn't a bug but marked as such.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - +1 to the idea. Paramsets are preferable to initParams because initParams are required to be present during initialization and therefore, a core reload is necessary when modifying them (is this documented in example solrconfigs and reference guide). But why only on implicit request handlers? Why not have this convention over all request handlers? Also, this isn't a bug but marked as such.
        Hide
        noble.paul Noble Paul added a comment -

        it is done with an explicit attribute in the configuration. We could change it in all our solrconfig.xml files. But they are ugly

        Show
        noble.paul Noble Paul added a comment - it is done with an explicit attribute in the configuration. We could change it in all our solrconfig.xml files. But they are ugly
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ecdfe97d34f6e808efc8e8efed6ce1306a4ee8e5 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecdfe97 ]

        SOLR-9557: Every implicit requesthandler now has a default 'useParams' attribute

        Show
        jira-bot ASF subversion and git services added a comment - Commit ecdfe97d34f6e808efc8e8efed6ce1306a4ee8e5 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecdfe97 ] SOLR-9557 : Every implicit requesthandler now has a default 'useParams' attribute
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 691472c0f0898ab99d16158ce5a6def60f754206 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=691472c ]

        SOLR-9557: Every implicit requesthandler now has a default 'useParams' attribute

        Show
        jira-bot ASF subversion and git services added a comment - Commit 691472c0f0898ab99d16158ce5a6def60f754206 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=691472c ] SOLR-9557 : Every implicit requesthandler now has a default 'useParams' attribute
        Hide
        romseygeek Alan Woodward added a comment -

        I think this has broken org.apache.solr.handler.component.StatsComponentTest.testPercentiles? Something to do with empty localparams no longer being reported as having null values, I think...

        Show
        romseygeek Alan Woodward added a comment - I think this has broken org.apache.solr.handler.component.StatsComponentTest.testPercentiles? Something to do with empty localparams no longer being reported as having null values, I think...
        Hide
        noble.paul Noble Paul added a comment -

        I shall check this out. But this has nothing to do with localparams

        Show
        noble.paul Noble Paul added a comment - I shall check this out. But this has nothing to do with localparams
        Hide
        noble.paul Noble Paul added a comment -

        yes. The optimization I did for StrUtils.splitSmart failed the test. Strange

        Show
        noble.paul Noble Paul added a comment - yes. The optimization I did for StrUtils.splitSmart failed the test. Strange
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f6622ef3748587a1636aeab046d4597cb475a18a in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f6622ef ]

        SOLR-9557: reverting an optimization

        Show
        jira-bot ASF subversion and git services added a comment - Commit f6622ef3748587a1636aeab046d4597cb475a18a in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f6622ef ] SOLR-9557 : reverting an optimization
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3f35cadd44a0515018bed079124731bc159d54d0 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3f35cad ]

        SOLR-9557: reverting an optimization

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3f35cadd44a0515018bed079124731bc159d54d0 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3f35cad ] SOLR-9557 : reverting an optimization
        Hide
        romseygeek Alan Woodward added a comment -

        Thanks!

        Show
        romseygeek Alan Woodward added a comment - Thanks!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 36cd9092922b8d03797dfcbf8bbff6efc9037f51 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36cd909 ]

        SOLR-9557: optimize splitsmart

        Show
        jira-bot ASF subversion and git services added a comment - Commit 36cd9092922b8d03797dfcbf8bbff6efc9037f51 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36cd909 ] SOLR-9557 : optimize splitsmart
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 208e2bc66f9b931feb0a168f0ef62a7bf27a9764 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=208e2bc ]

        SOLR-9557: optimize splitsmart

        Show
        jira-bot ASF subversion and git services added a comment - Commit 208e2bc66f9b931feb0a168f0ef62a7bf27a9764 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=208e2bc ] SOLR-9557 : optimize splitsmart
        Hide
        ctargett Cassandra Targett added a comment -

        Noble Paul - can you provide some information on how people should use this, for the Solr Ref Guide? I'm guessing this should go in the https://cwiki.apache.org/confluence/display/solr/Request+Parameters+API section on useParams.

        Show
        ctargett Cassandra Targett added a comment - Noble Paul - can you provide some information on how people should use this, for the Solr Ref Guide? I'm guessing this should go in the https://cwiki.apache.org/confluence/display/solr/Request+Parameters+API section on useParams.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            noble.paul Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development