Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9522

Improve error handling in ZKPropertiesWriter

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, master (7.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      In ZKPropertiesWriter we can improve error handling in a couple of ways:

      1. In readIndexerProperties we catch Exception , the exception can be an InterruptedException in which case we should be setting the flag.
      2. in readIndexerProperties we read the data , and I think it makes sense to retry on connection loss.

      1. SOLR-9522.patch
        3 kB
        Varun Thacker

        Activity

        Hide
        varunthacker Varun Thacker added a comment -

        Simple patch.

        I'll run the tests and commit this shortly

        Show
        varunthacker Varun Thacker added a comment - Simple patch. I'll run the tests and commit this shortly
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5d6b7fffc3e09efd908729340a587a274e9bdc72 in lucene-solr's branch refs/heads/master from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5d6b7ff ]

        SOLR-9522: Improve error handling in ZKPropertiesWriter

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5d6b7fffc3e09efd908729340a587a274e9bdc72 in lucene-solr's branch refs/heads/master from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5d6b7ff ] SOLR-9522 : Improve error handling in ZKPropertiesWriter
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f728a646f388733cfb57f8d4d9a0d9217f42fd38 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f728a64 ]

        SOLR-9522: Improve error handling in ZKPropertiesWriter

        Show
        jira-bot ASF subversion and git services added a comment - Commit f728a646f388733cfb57f8d4d9a0d9217f42fd38 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f728a64 ] SOLR-9522 : Improve error handling in ZKPropertiesWriter
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            varunthacker Varun Thacker
            Reporter:
            varunthacker Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development