Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9505

Extra tests to confirm Atomic Update remove behaviour

    XMLWordPrintableJSON

Details

    • Test
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 7.0
    • None
    • None
    • None

    Description

      The behaviour of the Atomic Update remove operation in the code doesn't match the description in the Confluence documentation, which has been questioned already. From looking at the source code, and using curl to confirm, the remove operation only removes the first occurrence of a value from a multi-valued field, it does not remove all occurrences. The removeregex operation does remove all, however.

      There are unit tests for Atomic Updates, but they didn't assert this behaviour, so I've added some extra assertions to confirm that, and a couple of extra tests including one that checks that removeregex does a Regex match of the whole value, not just a find-anywhere operation.

      I think it's the documentation that needs clarifying - the code behaves as expected (assuming remove was intended to work that way?)

      Attachments

        1. SOLR-9505.patch
          13 kB
          Tim Owen

        Activity

          People

            Unassigned Unassigned
            TimOwen Tim Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: