[SOLR-9413] String.replace Function result is ignored in lucene/analysis/kuromoji CSVUtil.quoteEscape

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.1
• Fix Version/s: 6.2, 7.0
• Assignee: Christine Poerschke
• Reporter: AppChecker
• Created: 13/Aug/16 14:42
• Updated: 08/Jun/19 15:37
• Resolved: 17/Aug/16 15:14

Description

Hello!

Code in the method CSVUtil. quoteEscape

CSVUtil.java

    if (result.indexOf('\"') >= 0) {
      result.replace("\"", ESCAPED_QUOTE);
    }

ignores the return value of the String.replace method.

Probably, is should be:

CSVUtil.java

    if (result.indexOf('\"') >= 0) {
      result = result.replace("\"", ESCAPED_QUOTE);
    }

This possible defect found by static code analyzer AppChecker