Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9331

Can we remove ReRankQuery's length constructor argument?

    XMLWordPrintableJSON

Details

    • Wish
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 6.2, 7.0
    • None
    • None

    Description

      Can we remove ReRankQuery's length constructor argument? It is a ReRankQParserPlugin private class.

      proposed patch summary:

      • change ReRankQuery.getTopDocsCollector to use its len argument (instead of the length member)
      • remove ReRankQuery's length member and constructor argument
      • remove ReRankQParser.parse's use of the rows and start parameters

      motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542) sharing (more) code

      Attachments

        1. SOLR-9331.patch
          3 kB
          Christine Poerschke
        2. SOLR-9331.patch
          3 kB
          Christine Poerschke

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. SOLR-9336 ReRankQuery.(hashCode|equalsTo) to consider length

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is required by

          New Feature - A new feature of the product, which has yet to be developed. SOLR-8542 Integrate Learning to Rank into Solr

          • Major - Major loss of function.
          • Resolved

          Activity

            People

              cpoerschke Christine Poerschke
              cpoerschke Christine Poerschke
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: