Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9331

Can we remove ReRankQuery's length constructor argument?

    Details

    • Type: Wish
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Can we remove ReRankQuery's length constructor argument? It is a ReRankQParserPlugin private class.

      proposed patch summary:

      • change ReRankQuery.getTopDocsCollector to use its len argument (instead of the length member)
      • remove ReRankQuery's length member and constructor argument
      • remove ReRankQParser.parse's use of the rows and start parameters

      motivation: towards ReRankQParserPlugin and LTRQParserPlugin (SOLR-8542) sharing (more) code

        Attachments

        1. SOLR-9331.patch
          3 kB
          Christine Poerschke
        2. SOLR-9331.patch
          3 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: