Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9303

Refactor CloudSolrClient for extensibility

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 5.4, 6.0
    • Fix Version/s: 6.1
    • Component/s: SolrJ
    • Labels:

      Description

      I'm using a custom Solr plugins which adds extra constraints on which nodes I can access.

      To respect these constraints, I needed to use a customized version of CloudSolrClient.

      Unfortunately, CloudSolrClient.sendRequest() is currently written as one big chunk of code, breaking OO's SOLID principle and making it is impossible for me to customize it on a subclass.

      I suggest we refactor this method in 3 steps:

      • Finding the usable URLs
      • Checking if a node can be used for this request
      • Executing the request

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                paulo_raca Paulo Costa
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Remaining Estimate - 24h
                  24h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified