Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-924

Solr: Making finalizers call super.finalize() wrapped in try..finally block

    XMLWordPrintableJSON

Details

    Description

      There are some occurences of finalizers in the code base. While the presence of them is debatable and discussed in a separate JIRA - the ones that are retained are better off wrapped around a try .. finally block to recursively call the finalizer of the super class for proper resource usage unwinding , (in case finalizers get invoked ).

      Attachments

        1. SOLR-924.patch
          3 kB
          Karthik K

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-914 Presence of finalize() in the codebase

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-914 Presence of finalize() in the codebase

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              hossman Chris M. Hostetter
              kaykay.unique Karthik K
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified