Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9216

Support collection.configName in MODIFYCOLLECTION request

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2
    • Component/s: None
    • Labels:
      None

      Description

      MODIFYCOLLECTION should support updating the /collections/<collectionname> value of "configName" in zookeeper

      1. SOLR-9216.patch
        16 kB
        Noble Paul
      2. SOLR-9216.patch
        12 kB
        Keith Laban
      3. SOLR-9216.patch
        13 kB
        Keith Laban

        Activity

        Hide
        k317h Keith Laban added a comment -

        Noble Paul looks like you did the original work on MODIFYCOLLECTION. Would you mind taking a look?

        I put the test into RulesTest, although I'm not sure this is the best place to put the test, it was the only spot I could find that this request was being tested. If you would like I can move it separate class.

        Show
        k317h Keith Laban added a comment - Noble Paul looks like you did the original work on MODIFYCOLLECTION. Would you mind taking a look? I put the test into RulesTest, although I'm not sure this is the best place to put the test, it was the only spot I could find that this request was being tested. If you would like I can move it separate class.
        Hide
        noble.paul Noble Paul added a comment -

        Sorry, lost track. I shall review it today

        Show
        noble.paul Noble Paul added a comment - Sorry, lost track. I shall review it today
        Hide
        noble.paul Noble Paul added a comment -

        Yeah, the testcase is the problem. RulesTest is not the right place to do it. We should add it elsewhere

        Show
        noble.paul Noble Paul added a comment - Yeah, the testcase is the problem. RulesTest is not the right place to do it. We should add it elsewhere
        Hide
        k317h Keith Laban added a comment -

        removed changes from RulesTest and added an OverseerModifyCollectionTest with this testcase

        Show
        k317h Keith Laban added a comment - removed changes from RulesTest and added an OverseerModifyCollectionTest with this testcase
        Hide
        noble.paul Noble Paul added a comment -

        we must reload a collection after changing the config name

        Show
        noble.paul Noble Paul added a comment - we must reload a collection after changing the config name
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1dc7480bcdfba1e9c854172e19e8cc6ba96144d2 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1dc7480 ]

        SOLR-9216: Support collection.configName in MODIFYCOLLECTION request

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1dc7480bcdfba1e9c854172e19e8cc6ba96144d2 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1dc7480 ] SOLR-9216 : Support collection.configName in MODIFYCOLLECTION request
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ce3ea76781c79b700a09a4c5fa36621af14016de in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ce3ea76 ]

        SOLR-9216: Support collection.configName in MODIFYCOLLECTION request

        Show
        jira-bot ASF subversion and git services added a comment - Commit ce3ea76781c79b700a09a4c5fa36621af14016de in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ce3ea76 ] SOLR-9216 : Support collection.configName in MODIFYCOLLECTION request
        Hide
        k317h Keith Laban added a comment -

        Noble Paul did you mean to commit that change to SolrParams?

        Show
        k317h Keith Laban added a comment - Noble Paul did you mean to commit that change to SolrParams?
        Hide
        k317h Keith Laban added a comment -

        Never mind, I didn't realize you made a change to use it in some of the other classes

        Show
        k317h Keith Laban added a comment - Never mind, I didn't realize you made a change to use it in some of the other classes
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            k317h Keith Laban
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development