Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9003

New Admin UI does not display DIH Debug output

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.2, 7.0
    • Component/s: Admin UI
    • Labels:
      None

      Description

      When enabling Debug flag in DIH Dataimport screen, a new section Raw Debug-Response is added.

      In the new Admin UI, it does not seem to show the output, just No Request executed

      This was tested using the db core of the example-DIH setup.

      1. New Admin-UI.png
        608 kB
        Alexandre Rafalovitch
      2. Old Admin-UI.png
        625 kB
        Alexandre Rafalovitch

        Issue Links

          Activity

          Hide
          beffy72 Stefan Moises added a comment -

          I can confirm this. We keep switching back and forth between the different UIs... what makes it worse for us is that for the old UI, we currently get an Exception executing the import (java.lang.UnsupportedOperationException at java.sql.Date.toInstant) which shows up as "Unknown error" in the error log... in the new UI, the import works fine, but we can't check the generated SQL query since the "Raw Debug-Response" is empty ...

          Show
          beffy72 Stefan Moises added a comment - I can confirm this. We keep switching back and forth between the different UIs... what makes it worse for us is that for the old UI, we currently get an Exception executing the import (java.lang.UnsupportedOperationException at java.sql.Date.toInstant) which shows up as "Unknown error" in the error log... in the new UI, the import works fine, but we can't check the generated SQL query since the "Raw Debug-Response" is empty ...
          Hide
          arafalov Alexandre Rafalovitch added a comment - - edited

          Ok, I begin to see the problem.

          There are four debug things:

          • Raw Status-Output which shows the latest status and is always populated. This gets refreshed on Execute, on Refresh and on Auto-Refresh (if enabled)
          • Debug checkbox that enables Raw Debug-Response section AND adds debug=true flag to the execute POST request. Then - in Execute only - it populates the Raw Debug-Response section. Refresh does nothing to that
          • Debug-Mode hammer in the Configuration section that allows to edit the configuration right on the screen instead of using the file AND - in the old UI - enables Debug checkbox if not already set
          • Verbose checkbox that adds an additional section to the debug output if that's enabled.

          It seems that the Debug checkbox is not actually wired in as the debug=true is never generated. And then, when the execute response is processed, the debug section itself is not populated. And the hammer does not trigger the checkbox either.

          This is mostly complicated due to the multiple debug in the naming conventions. So, it can be fixed without renaming. Or it can be fixed with renaming....

          Show
          arafalov Alexandre Rafalovitch added a comment - - edited Ok, I begin to see the problem. There are four debug things: Raw Status-Output which shows the latest status and is always populated. This gets refreshed on Execute, on Refresh and on Auto-Refresh (if enabled) Debug checkbox that enables Raw Debug-Response section AND adds debug=true flag to the execute POST request. Then - in Execute only - it populates the Raw Debug-Response section. Refresh does nothing to that Debug-Mode hammer in the Configuration section that allows to edit the configuration right on the screen instead of using the file AND - in the old UI - enables Debug checkbox if not already set Verbose checkbox that adds an additional section to the debug output if that's enabled. It seems that the Debug checkbox is not actually wired in as the debug=true is never generated. And then, when the execute response is processed, the debug section itself is not populated. And the hammer does not trigger the checkbox either. This is mostly complicated due to the multiple debug in the naming conventions. So, it can be fixed without renaming. Or it can be fixed with renaming....
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arafalov opened a pull request:

          https://github.com/apache/lucene-solr/pull/61

          SOLR-9003: Fix various UI/DIH debug features

          Debug flag now sets the flag and displays the response
          Configuration debug-mode now actually sends changed configuration
          Enabling configuration debug-mode also turns on Debug mode flag

          This has been tested on Mac with Chrome and Firefox against DIH DB example.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arafalov/lucene-solr-contributions ALEX-SOLR-9003

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/61.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #61


          commit b0b4052bb6d11ca5f4e2a91359a00dd61b3068a1
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-08-03T09:06:18Z

          Merge pull request #1 from apache/master

          Update to latest Apache master

          commit 1d86ec0e88b3315a19258e2753b0d914a882c97e
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-08-03T15:00:05Z

          SOLR-9003: Fix various DIH debug flags interplay


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arafalov opened a pull request: https://github.com/apache/lucene-solr/pull/61 SOLR-9003 : Fix various UI/DIH debug features Debug flag now sets the flag and displays the response Configuration debug-mode now actually sends changed configuration Enabling configuration debug-mode also turns on Debug mode flag This has been tested on Mac with Chrome and Firefox against DIH DB example. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arafalov/lucene-solr-contributions ALEX- SOLR-9003 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit b0b4052bb6d11ca5f4e2a91359a00dd61b3068a1 Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-08-03T09:06:18Z Merge pull request #1 from apache/master Update to latest Apache master commit 1d86ec0e88b3315a19258e2753b0d914a882c97e Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-08-03T15:00:05Z SOLR-9003 : Fix various DIH debug flags interplay
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I believe this is the complete fix and would appreciate it being tested on a different machine against a large(r) DIH data source.

          Show
          arafalov Alexandre Rafalovitch added a comment - I believe this is the complete fix and would appreciate it being tested on a different machine against a large(r) DIH data source.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit dd03d39dd6624a5d41325397ca246e01b12ec71d in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd03d39 ]

          SOLR-9003: DIH Debug now works in new Admin UI

          Show
          jira-bot ASF subversion and git services added a comment - Commit dd03d39dd6624a5d41325397ca246e01b12ec71d in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dd03d39 ] SOLR-9003 : DIH Debug now works in new Admin UI
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e58c83f0aba8832eabc786a3a8dadd89099c8f61 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e58c83f ]

          SOLR-9003: DIH Debug now works in new Admin UI
          This resolves #61

          Show
          jira-bot ASF subversion and git services added a comment - Commit e58c83f0aba8832eabc786a3a8dadd89099c8f61 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e58c83f ] SOLR-9003 : DIH Debug now works in new Admin UI This resolves #61
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arafalov closed the pull request at:

          https://github.com/apache/lucene-solr/pull/61

          Show
          githubbot ASF GitHub Bot added a comment - Github user arafalov closed the pull request at: https://github.com/apache/lucene-solr/pull/61
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Fixed and tested against DIH DB example.

          Show
          arafalov Alexandre Rafalovitch added a comment - Fixed and tested against DIH DB example.
          Hide
          varunthacker Varun Thacker added a comment -

          Hi Alexandre,

          I guess its not a big deal but the new CHANGES entry is generally added towards to bottom of the list. I think you inserted it in sorted order of the Jira numbers.

          Show
          varunthacker Varun Thacker added a comment - Hi Alexandre, I guess its not a big deal but the new CHANGES entry is generally added towards to bottom of the list. I think you inserted it in sorted order of the Jira numbers.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          I did not see a guidance on this, so I added it next to the other Admin UI issues. I will make sure to put it on the bottom for the future issues. Thank you for pointing it out.

          Show
          arafalov Alexandre Rafalovitch added a comment - I did not see a guidance on this, so I added it next to the other Admin UI issues. I will make sure to put it on the bottom for the future issues. Thank you for pointing it out.
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              arafalov Alexandre Rafalovitch
              Reporter:
              arafalov Alexandre Rafalovitch
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development