Solr
  1. Solr
  2. SOLR-886

DataImportHandler should rollback when an import fails or is aborted

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      DataImportHandler should call rollback when an import fails or is aborted. This will make sure that uncommitted changes are not committed when the IndexWriter is closed.

      1. SOLR-886.patch
        0.7 kB
        Shalin Shekhar Mangar
      2. SOLR-886.patch
        4 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Rollback if an import is aborted or if an exception is thrown during full or delta imports.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Rollback if an import is aborted or if an exception is thrown during full or delta imports. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 725616.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 725616.
        Hide
        Shalin Shekhar Mangar added a comment -

        For rollback to work, a commit needs to be called. The committed code was not correct. I'll give another patch shortly.

        Show
        Shalin Shekhar Mangar added a comment - For rollback to work, a commit needs to be called. The committed code was not correct. I'll give another patch shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Attached patch fixes the issue. I plan to commit shortly.

        Show
        Shalin Shekhar Mangar added a comment - Attached patch fixes the issue. I plan to commit shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 727357.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 727357.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development