[SOLR-8836] /update should return BAD REQUEST when invalid JSON provided

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 6.0
• Assignee: Anshum Gupta
• Reporter: Jason Gerlowski
• Created: 13/Mar/16 03:24
• Updated: 09/May/16 18:51
• Resolved: 15/Mar/16 19:16

Description

When a user provides invalid JSON to the /update endpoint, the request fails with a 500 (INTERNAL SERVER ERROR). If the user looks at the response body, they'll see a message indicating that the provided JSON was invalid. However, going from the status code alone, the failure is indistinguishable from a true server-error. This is a bit misleading. It would be nice if Solr instead returned a 400 (BAD REQUEST) status code when it detects invalid arguments.

Reproduction Steps:
1.) bin/solr start -e cloud -noprompt
2.) curl -i -l -k -X POST -H 'Content-Type: application/json' 'http://localhost:8983/solr/gettingstarted/update' --data-binary '}{'