In the test, it appears System.setProperty("enable.update.log", "false"); // schema12 doesn't support version is not needed since you don't use schema12
fixed – thanks
I suggest initializing the HashMap of the built-in transformers with the no-arg constructor (TransformerFactory.java), and same thing for the response writers (SolrCore.java). It's not worth it in trying in trying to optimize & maintain anything else. I realize you didn't introduce these but I suggest ending it now.
Lets open another issue if you care about this... i don't know enough to say, and don't want that discussion to get lost in this issue
Personally I'd find it far easier to interpret the test if I was looking at the JSON string or toString'ed Map or whatever it is, versus the laborious extraction of each part of the data structure. If you disagree, leave it.
I think the tests have a good mix of this – some are testing with strings and others are checking the direct element. (Where parsing is important)
GeoTransformerFactory.java doesn't compile for me; it references GeoJSONResponseWriter.FIELD which doesn't exist. The patch file itself seemed strange; seemed like a list of commits and not one patch. Maybe this is related.
sorry, my git patch was weird. It was the 'patch' flavor, not the 'diff' flavor