Hi Scott, yes this should work fine. Sorry for being out of the loop re:
SOLR-8696. I was travelling back to India and had a terrible jet lag.
Also, what's the right way to handle things if the remote call fails? Will the code throw before it reaches the wait loop, or should I try to inspect the response object for errors before deciding to wait? I didn't see any special handling at other call sites.
Hmm, good question. The processResponses method will throw an exception if abortOnError=true (which it is, in this case) but the 'async' handling does not throw any exceptions. So if the remote call fails and the user had specified the 'async' parameter, the wait loop will still be invoked.