Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8698

params.json should have a way to specify appends and invariants

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None

      Description

      params.json only supports defaults today. It should be possible to add appends and invariants

      for example

      {
      "params":{
      
      "my_param_set" : {
      "a":"A",
      "b" :"B",
      "_appends_" : {
      "c": "C"
      },
      "_invariants_":{
      "d" : "D"
      }}
      }
      

      In this case variables a and b are defaults, c is appends and d is invariants

      The fact that we can have invariants and appends means that if a useParam is specified with the component, it should not be overridable from the request

      So, this introduces a back incompat change

        Activity

        Hide
        noble.paul Noble Paul added a comment -

        Erik Hatcher From 6.0 onwards we are making this much needed change and params now have the full capabilities of standard requesthandler definitions.

        Show
        noble.paul Noble Paul added a comment - Erik Hatcher From 6.0 onwards we are making this much needed change and params now have the full capabilities of standard requesthandler definitions.
        Hide
        noble.paul Noble Paul added a comment -

        all required changes as per the description and necessary changes in the tests

        Show
        noble.paul Noble Paul added a comment - all required changes as per the description and necessary changes in the tests
        Hide
        ehatcher Erik Hatcher added a comment -

        Noble Paul sweet! this will allow the workaround in example/files solrconfig.xml for /browse and the appended parameter.

        Show
        ehatcher Erik Hatcher added a comment - Noble Paul sweet! this will allow the workaround in example/files solrconfig.xml for /browse and the appended parameter.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9ce2d0d25df7d619ef9ea16a8b5e7f5341d3fc71 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ce2d0d ]

        SOLR-8698: params.json can now have appends and invariants as well. 'useParams' specified in the requestHandler is always applied

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9ce2d0d25df7d619ef9ea16a8b5e7f5341d3fc71 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ce2d0d ] SOLR-8698 : params.json can now have appends and invariants as well. 'useParams' specified in the requestHandler is always applied
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9ce2d0d25df7d619ef9ea16a8b5e7f5341d3fc71 in lucene-solr's branch refs/heads/apiv2 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ce2d0d ]

        SOLR-8698: params.json can now have appends and invariants as well. 'useParams' specified in the requestHandler is always applied

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9ce2d0d25df7d619ef9ea16a8b5e7f5341d3fc71 in lucene-solr's branch refs/heads/apiv2 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ce2d0d ] SOLR-8698 : params.json can now have appends and invariants as well. 'useParams' specified in the requestHandler is always applied
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1734d03eb9f92d53f99b5652e239064519e1ba79 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1734d03 ]

        SOLR-8698: changes the example config to reflect the new behavior

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1734d03eb9f92d53f99b5652e239064519e1ba79 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1734d03 ] SOLR-8698 : changes the example config to reflect the new behavior
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1734d03eb9f92d53f99b5652e239064519e1ba79 in lucene-solr's branch refs/heads/jira/SOLR-445 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1734d03 ]

        SOLR-8698: changes the example config to reflect the new behavior

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1734d03eb9f92d53f99b5652e239064519e1ba79 in lucene-solr's branch refs/heads/jira/ SOLR-445 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1734d03 ] SOLR-8698 : changes the example config to reflect the new behavior

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            noble.paul Noble Paul
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development