Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8656

PeerSync should use same nUpdates everywhere

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 5.4.1, 6.0
    • 5.5.1, 6.0
    • SolrCloud
    • None

    Description

      PeerSync requests information on the most recent nUpdates updates from another instance to determine whether PeerSync can succeed. The value of nUpdates can be customized in solrconfig.xml: UpdateHandler.UpdateLog.NumRecordsToKeep.

      PeerSync can be initiated in a number of different paths. One path to start PeerSync (leader-initiated sync) is incorrectly still using a hard-coded value of nUpdates=100.

      This change fixes leader-initiated-sync code path to also pick up the value of nUpdates from the customized/configured value.

      Attachments

        Issue Links

        is related to

        Improvement - An improvement or enhancement to an existing feature or task. SOLR-6359 Allow customization of the number of records and logs kept by UpdateLog

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            anshum Anshum Gupta
            rwhaddad Ramsey Haddad
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment