Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8656

PeerSync should use same nUpdates everywhere

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.4.1, 6.0
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    • Flags:
      Patch

      Description

      PeerSync requests information on the most recent nUpdates updates from another instance to determine whether PeerSync can succeed. The value of nUpdates can be customized in solrconfig.xml: UpdateHandler.UpdateLog.NumRecordsToKeep.

      PeerSync can be initiated in a number of different paths. One path to start PeerSync (leader-initiated sync) is incorrectly still using a hard-coded value of nUpdates=100.

      This change fixes leader-initiated-sync code path to also pick up the value of nUpdates from the customized/configured value.

      1. solr-8656.patch
        2 kB
        Ramsey Haddad

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 771f14cb6e476373e94169be05c1eadf816ca5b6 in lucene-solr's branch refs/heads/master from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=771f14c ]

          SOLR-8656: PeerSync should use same nUpdates everywhere.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 771f14cb6e476373e94169be05c1eadf816ca5b6 in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=771f14c ] SOLR-8656 : PeerSync should use same nUpdates everywhere.
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Thanks Ramsey!

          Show
          markrmiller@gmail.com Mark Miller added a comment - Thanks Ramsey!
          Hide
          anshumg Anshum Gupta added a comment -

          Reopening to back port for 5.5.1

          Show
          anshumg Anshum Gupta added a comment - Reopening to back port for 5.5.1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d2f68e13c660291f460b4b5e54c8a95643497eea in lucene-solr's branch refs/heads/branch_5x from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d2f68e1 ]

          SOLR-8656: PeerSync should use same nUpdates everywhere.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d2f68e13c660291f460b4b5e54c8a95643497eea in lucene-solr's branch refs/heads/branch_5x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d2f68e1 ] SOLR-8656 : PeerSync should use same nUpdates everywhere.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9f7bd67d2d34be1548fff6f2f44a4146b9d28b13 in lucene-solr's branch refs/heads/branch_5_5 from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f7bd67 ]

          SOLR-8656: PeerSync should use same nUpdates everywhere.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9f7bd67d2d34be1548fff6f2f44a4146b9d28b13 in lucene-solr's branch refs/heads/branch_5_5 from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f7bd67 ] SOLR-8656 : PeerSync should use same nUpdates everywhere.

            People

            • Assignee:
              anshumg Anshum Gupta
              Reporter:
              rwhaddad Ramsey Haddad
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development