Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8612

DIH JdbcDataSource - statement not always closed

    XMLWordPrintableJSON

Details

    Description

      There are several cases where the Statement used by JdbcDataSource is not closed, potentially resulting in too many open connections:

      • an exception is throw in the ResultSetIterator constructor
      • the result set is null in the ResultSetIterator constructor
      • an exception is thrown during import and the import is aborted (onError flag set to abort)

      Attachments

        1. SOLR-8612.patch
          11 kB
          Kristine Jetzke
        2. SOLR-8612.patch
          16 kB
          Kristine Jetzke
        3. SOLR-8612.patch
          16 kB
          Kristine Jetzke
        4. SOLR-8612.patch
          17 kB
          Kristine Jetzke
        5. SOLR-8612.patch
          17 kB
          Mikhail Khludnev

        Issue Links

          contains

          Bug - A problem which impairs or prevents the functions of the product. SOLR-9256 Solr 6.x DataImportHandler fails with postgreSQL dataSource with multiple joined entities

          • Major - Major loss of function.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-3409 NPE: JdbcDataSource should handle null ResultSet

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link GitHub Pull Request #6

          Activity

            People

              mkhl Mikhail Khludnev
              tinexw Kristine Jetzke
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: