Solr
  1. Solr
  2. SOLR-8486

No longer require jar/unzip for bin/solr

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      Now that we do not ship with a .war anymore, the bin/solr script has some dead code related to UNPACK_WAR_CMD, see comment in this pull request.

      1. SOLR-8486.patch
        1 kB
        Jan Høydahl

        Activity

        Hide
        ASF GitHub Bot added a comment -

        Github user janhoy commented on the pull request:

        https://github.com/apache/lucene-solr/commit/c4bbf9cc5e8b1869d40cd7f619e40c8a4864d531#commitcomment-15254841

        In solr/bin/solr:
        In solr/bin/solr on line 53:
        You are right. Opened https://issues.apache.org/jira/browse/SOLR-8486 to deal with it.

        Show
        ASF GitHub Bot added a comment - Github user janhoy commented on the pull request: https://github.com/apache/lucene-solr/commit/c4bbf9cc5e8b1869d40cd7f619e40c8a4864d531#commitcomment-15254841 In solr/bin/solr: In solr/bin/solr on line 53: You are right. Opened https://issues.apache.org/jira/browse/SOLR-8486 to deal with it.
        Hide
        Steven E. Harris added a comment -

        Thank you. Shall I create a pull request to remove it?

        Show
        Steven E. Harris added a comment - Thank you. Shall I create a pull request to remove it?
        Hide
        Jan Høydahl added a comment -

        No need for a separate PR, I'll attach a patch here

        Show
        Jan Høydahl added a comment - No need for a separate PR, I'll attach a patch here
        Hide
        Jan Høydahl added a comment -

        Attaching patch for trunk

        Show
        Jan Høydahl added a comment - Attaching patch for trunk
        Hide
        ASF subversion and git services added a comment -

        Commit 1722988 from janhoy@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1722988 ]

        SOLR-8486: No longer require jar/unzip for bin/solr

        Show
        ASF subversion and git services added a comment - Commit 1722988 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1722988 ] SOLR-8486 : No longer require jar/unzip for bin/solr
        Hide
        ASF subversion and git services added a comment -

        Commit 1722989 from janhoy@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1722989 ]

        SOLR-8486: No longer require jar/unzip for bin/solr (backport)

        Show
        ASF subversion and git services added a comment - Commit 1722989 from janhoy@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1722989 ] SOLR-8486 : No longer require jar/unzip for bin/solr (backport)
        Hide
        Jan Høydahl added a comment -

        Thanks for reporting, Steven E. Harris

        Show
        Jan Høydahl added a comment - Thanks for reporting, Steven E. Harris
        Hide
        Steven E. Harris added a comment -

        And thank you for the prompt fix. I look forward to Solr 5.5.

        Show
        Steven E. Harris added a comment - And thank you for the prompt fix. I look forward to Solr 5.5.

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development