Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8467

CloudSolrStream and FacetStream should take a SolrParams object rather than a Map<String, String> to allow more complex Solr queries to be specified

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.1, 7.0
    • None
    • None

    Description

      Currently, it's impossible to, say, specify multiple "fq" clauses when using Streaming Aggregation due to the fact that the c'tors take a Map of params.

      Opening to discuss whether we should
      1> deprecate the current c'tor
      and/or
      2> add a c'tor that takes a SolrParams object instead.
      and/or
      3> ???

      I don't see a clean way to go from a Map<String, String> to a (Modifiable)SolrParams, so existing code would need a significant change. I hacked together a PoC, just to see if I could make CloudSolrStream take a ModifiableSolrParams object instead and it passes tests, but it's so bad that I'm not going to even post it. There's got to be a better way to do this, but at least it's possible....

      Attachments

        1. SOLR-8647.patch
          45 kB
          Erick Erickson
        2. SOLR-8647.patch
          55 kB
          Erick Erickson
        3. SOLR-8467.patch
          56 kB
          Erick Erickson
        4. SOLR-8467.patch
          155 kB
          Erick Erickson
        5. SOLR-8467.patch
          142 kB
          Erick Erickson
        6. SOLR-8467.patch
          133 kB
          Erick Erickson
        7. SOLR-8467.patch
          144 kB
          Erick Erickson
        8. SOLR-8467.patch
          144 kB
          Erick Erickson
        9. SOLR-8467.patch
          156 kB
          Erick Erickson

        Activity

          People

            erickerickson Erick Erickson
            erickerickson Erick Erickson
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: