Solr
  1. Solr
  2. SOLR-8294

Cleanup solrconfig.xmls under solr/example/example-DIH/solr

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Information Provided
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This confused me. There are numerous solrconfig.xml under example-DIH, all of these configs specify a number of things other than DIH configuration (for example all of them specify the clustering plugin).

      Is this intentional? I would clean up the clustering plugin's config from there as it doesn't seem to be relevant to DIH and results in duplication (and possibly confusion).

      1. SOLR-8294.patch
        25 kB
        Dawid Weiss

        Issue Links

          Activity

          Hide
          Dawid Weiss added a comment -

          Also, the configs aren't even consistent – for example db/conf/solrconfig.xml is the only one containing QueryElevationComponent section.

          Show
          Dawid Weiss added a comment - Also, the configs aren't even consistent – for example db/conf/solrconfig.xml is the only one containing QueryElevationComponent section.
          Hide
          Dawid Weiss added a comment -

          This patch removes the clustering config from DIHs examples. The clustering config example is still present in configsets\sample_techproducts_configs\conf\ solrconfig.xml.

          Show
          Dawid Weiss added a comment - This patch removes the clustering config from DIHs examples. The clustering config example is still present in configsets\sample_techproducts_configs\conf\ solrconfig.xml .
          Hide
          Alexandre Rafalovitch added a comment -

          The schema.xml also have the same problem of having all those hundreds of field type definitions that are not used and are out of sync with more recent examples.

          I think the DIH examples should focus on absolute minimum needed to show off the DIH itself. People can copy other bits from other examples if they are building starting from DIH example.

          Show
          Alexandre Rafalovitch added a comment - The schema.xml also have the same problem of having all those hundreds of field type definitions that are not used and are out of sync with more recent examples. I think the DIH examples should focus on absolute minimum needed to show off the DIH itself. People can copy other bits from other examples if they are building starting from DIH example.
          Hide
          Dawid Weiss added a comment -

          Yeah, I agree with you. I just don't have that much experience with DIH to know what's actually the core of its functionality. Can you provide a patch that would clean it up? Otherwise I'll just remove the bits I know about (patch) and leave the issue open for the future.

          Show
          Dawid Weiss added a comment - Yeah, I agree with you. I just don't have that much experience with DIH to know what's actually the core of its functionality. Can you provide a patch that would clean it up? Otherwise I'll just remove the bits I know about (patch) and leave the issue open for the future.
          Hide
          Alexandre Rafalovitch added a comment -

          Actually (on a second thought), it might be best to spin that idea into a separate JIRA as it is more about schema.xml than solrconfig.xml. This one is a clean single-issue JIRA.

          Show
          Alexandre Rafalovitch added a comment - Actually (on a second thought), it might be best to spin that idea into a separate JIRA as it is more about schema.xml than solrconfig.xml. This one is a clean single-issue JIRA.
          Hide
          ASF subversion and git services added a comment -

          Commit 1714856 from Dawid Weiss in branch 'dev/trunk'
          [ https://svn.apache.org/r1714856 ]

          SOLR-8294: Cleanup solrconfig.xmls under solr/example/example-DIH/solr (removed obsolete clustering handler sections).

          Show
          ASF subversion and git services added a comment - Commit 1714856 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1714856 ] SOLR-8294 : Cleanup solrconfig.xmls under solr/example/example-DIH/solr (removed obsolete clustering handler sections).
          Hide
          ASF subversion and git services added a comment -

          Commit 1714857 from Dawid Weiss in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1714857 ]

          SOLR-8294: Cleanup solrconfig.xmls under solr/example/example-DIH/solr (removed obsolete clustering handler sections).

          Show
          ASF subversion and git services added a comment - Commit 1714857 from Dawid Weiss in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1714857 ] SOLR-8294 : Cleanup solrconfig.xmls under solr/example/example-DIH/solr (removed obsolete clustering handler sections).
          Hide
          Dawid Weiss added a comment -

          Reopening for further cleanups of solrconfig.xml

          Show
          Dawid Weiss added a comment - Reopening for further cleanups of solrconfig.xml
          Hide
          Alexandre Rafalovitch added a comment -

          I think this 'cleanup' issue has passed its time. I suggest we open a new one and perhaps look into converting DIH examples into an absolute minimal set of configurations that demonstrate DIH-specific features.

          Show
          Alexandre Rafalovitch added a comment - I think this 'cleanup' issue has passed its time. I suggest we open a new one and perhaps look into converting DIH examples into an absolute minimal set of configurations that demonstrate DIH-specific features.

            People

            • Assignee:
              Unassigned
              Reporter:
              Dawid Weiss
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development