Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8285

Ensure the /export handler works with NULL field values.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 6.0
    • Component/s: None
    • Labels:
      None
    1. SOLR-8285.patch
      13 kB
      Joel Bernstein
    2. SOLR-8285.patch
      10 kB
      Joel Bernstein
    3. SOLR-8285.patch
      7 kB
      Joel Bernstein

      Issue Links

        Activity

        Hide
        joel.bernstein Joel Bernstein added a comment -

        Patch with the first pass at handling nulls in both sort fields and the export field list.

        Null fields for strings and multi-value fields will be left off the record. Numeric nulls are sent as zero.

        Test are needed.

        Show
        joel.bernstein Joel Bernstein added a comment - Patch with the first pass at handling nulls in both sort fields and the export field list. Null fields for strings and multi-value fields will be left off the record. Numeric nulls are sent as zero. Test are needed.
        Hide
        joel.bernstein Joel Bernstein added a comment -

        Patch with existing TestSortingResponseWriter tests passing. Some tests were adjusted to match the NULL format.

        Show
        joel.bernstein Joel Bernstein added a comment - Patch with existing TestSortingResponseWriter tests passing. Some tests were adjusted to match the NULL format.
        Hide
        joel.bernstein Joel Bernstein added a comment - - edited

        Added a testNulls() method to the StreamExpressionTest. The SortingResponseWriter test has some null testing built in also but it's much easier to test the /export handler through a Streaming Expression.

        Also we'll need a way to compare the behavior of nulls from both the /select handler and the /export handler to make sure we have something that works for the SQLHandler. The StreamExpressionTest is the right place to switch back and forth between the two handlers.

        More tests to come.

        Show
        joel.bernstein Joel Bernstein added a comment - - edited Added a testNulls() method to the StreamExpressionTest. The SortingResponseWriter test has some null testing built in also but it's much easier to test the /export handler through a Streaming Expression. Also we'll need a way to compare the behavior of nulls from both the /select handler and the /export handler to make sure we have something that works for the SQLHandler. The StreamExpressionTest is the right place to switch back and forth between the two handlers. More tests to come.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e20820a04d1aff5ccde64b7183308454bda62fef in lucene-solr's branch refs/heads/master from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e20820a ]

        SOLR-8285: Ensure the /export handler works with NULL field values

        Show
        jira-bot ASF subversion and git services added a comment - Commit e20820a04d1aff5ccde64b7183308454bda62fef in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e20820a ] SOLR-8285 : Ensure the /export handler works with NULL field values
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 14a2c16ca4243e5f26b776639cb03ec5cefe3d2b in lucene-solr's branch refs/heads/master from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=14a2c16ca ]

        SOLR-8285: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit 14a2c16ca4243e5f26b776639cb03ec5cefe3d2b in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=14a2c16ca ] SOLR-8285 : Update CHANGES.txt
        Hide
        matteo.grolla Matteo Grolla added a comment -

        Wouldn't it be possible to leave off the record numeric docvalues?

        Show
        matteo.grolla Matteo Grolla added a comment - Wouldn't it be possible to leave off the record numeric docvalues?
        Hide
        erickerickson Erick Erickson added a comment -
        Show
        erickerickson Erick Erickson added a comment - Does https://issues.apache.org/jira/browse/SOLR-9166 address your question?

          People

          • Assignee:
            joel.bernstein Joel Bernstein
            Reporter:
            erickerickson Erick Erickson
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development