Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8101

Installation script permission issues and other scripts fixes

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 5.3.1
    • 5.4
    • scripts and tools

    Description

      Until https://issues.apache.org/jira/browse/SOLR-7871 is fixed, I suggest to improve current shell scripts. Provided patch:

      • changes $SOLR_ENV default to /etc/default/$SOLR_SERVICE.in.sh . This is security issue. If solr.in.sh is placed in directory which is writable by $SOLR_USER, solr process is able to write to it, and than it will be run by root on start/shutdown.
      • changes permissions. $SOLR_USER should only be able to write to $SOLR_VAR_DIR. This directory should not be readable by other users as it may contain personal information.
      • sets $SOLR_USER home directory to $SOLR_VAR_DIR . As I can see there is no need in /home/solr directory.
      • adds -f option to install_solr_service.sh. It should be used to safely upgrade Solr.
      • adds quotes to unquoted variables
      • adds leading zero to chmod commands
      • removes group from chown commands (uses ":")

      Tested on ubuntu 14.04 amd64, but changes are pretty system-independent.

      Attachments

        1. solr-5.3.1.patch
          8 kB
          Sergey Urushkin
        2. SOLR-8101.patch
          11 kB
          Timothy Potter
        3. solr-scripts-v2.patch
          11 kB
          Sergey Urushkin
        4. solr-scripts-v3.patch
          11 kB
          Sergey Urushkin

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            thelabdude Timothy Potter
            urusha Sergey Urushkin
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment