Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1703145 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1703145 ]

        SOLR-8053: Basic auth support in SolrJ

        Show
        ASF subversion and git services added a comment - Commit 1703145 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1703145 ] SOLR-8053 : Basic auth support in SolrJ
        Hide
        ASF subversion and git services added a comment -

        Commit 1703173 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1703173 ]

        SOLR-8053: Basic auth support in SolrJ

        Show
        ASF subversion and git services added a comment - Commit 1703173 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1703173 ] SOLR-8053 : Basic auth support in SolrJ
        Hide
        Yonik Seeley added a comment -

        I don't know that much about security, but could you explain a little about how this works in with the existing basic auth stuff in HttpClientUtil:

          // Basic auth username 
          public static final String PROP_BASIC_AUTH_USER = "httpBasicAuthUser";
          // Basic auth password 
          public static final String PROP_BASIC_AUTH_PASS = "httpBasicAuthPassword";
        

        What the issues were with the existing basic auth stuff and how this patch changes that?

        Show
        Yonik Seeley added a comment - I don't know that much about security, but could you explain a little about how this works in with the existing basic auth stuff in HttpClientUtil: // Basic auth username public static final String PROP_BASIC_AUTH_USER = "httpBasicAuthUser" ; // Basic auth password public static final String PROP_BASIC_AUTH_PASS = "httpBasicAuthPassword" ; What the issues were with the existing basic auth stuff and how this patch changes that?
        Hide
        Noble Paul added a comment -

        but could you explain a little about how this works in with the existing basic auth stuff in HttpClientUtil

        This was a hack introduced to add the basic auth headers when Solr makes inter-node requests. After 5.3 we have native support for inter-node authentication. This lets you to have only one user/pwd combination in the entire cluster which meant all requests were performed as same user

        IMHO we should deprecate this.

        This ticket makes the user/pwd configurable of a per request basis.

        SolrRequest req ;//create  anew request object
        req.setBasicAuthCredentials(userName,  password);
        solrClient.request(req);
        
        Show
        Noble Paul added a comment - but could you explain a little about how this works in with the existing basic auth stuff in HttpClientUtil This was a hack introduced to add the basic auth headers when Solr makes inter-node requests. After 5.3 we have native support for inter-node authentication. This lets you to have only one user/pwd combination in the entire cluster which meant all requests were performed as same user IMHO we should deprecate this. This ticket makes the user/pwd configurable of a per request basis. SolrRequest req ; //create anew request object req.setBasicAuthCredentials(userName, password); solrClient.request(req);
        Hide
        Hrishikesh Gadre added a comment -

        I just filed SOLR-8056 to provide similar support at the SolrClient level as well.

        Show
        Hrishikesh Gadre added a comment - I just filed SOLR-8056 to provide similar support at the SolrClient level as well.

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development