Solr
  1. Solr
  2. SOLR-7972

VelocityResponseWriter template encoding issue

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 5.3
    • Fix Version/s: 5.3.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I'm not sure when this got introduced (5.0 maybe?) - the .vm templates are loaded using ISO-8859-1 rather than UTF-8 as it should be.

      1. SOLR-7972.patch
        2 kB
        Erik Hatcher

        Activity

        Hide
        Erik Hatcher added a comment -

        Here's a patch with a test case that demonstrates the issue and the associated fix.

        Show
        Erik Hatcher added a comment - Here's a patch with a test case that demonstrates the issue and the associated fix.
        Hide
        ASF subversion and git services added a comment -

        Commit 1697789 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1697789 ]

        SOLR-7972: Fix VelocityResponseWriter template encoding issue

        Show
        ASF subversion and git services added a comment - Commit 1697789 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1697789 ] SOLR-7972 : Fix VelocityResponseWriter template encoding issue
        Hide
        ASF subversion and git services added a comment -

        Commit 1697790 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1697790 ]

        SOLR-7972: Fix VelocityResponseWriter template encoding issue (merged from trunk r1697789)

        Show
        ASF subversion and git services added a comment - Commit 1697790 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697790 ] SOLR-7972 : Fix VelocityResponseWriter template encoding issue (merged from trunk r1697789)
        Hide
        ASF subversion and git services added a comment -

        Commit 1697791 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1697791 ]

        SOLR-7972: Fix VelocityResponseWriter template encoding issue (merged from trunk r1697789)

        Show
        ASF subversion and git services added a comment - Commit 1697791 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697791 ] SOLR-7972 : Fix VelocityResponseWriter template encoding issue (merged from trunk r1697789)
        Hide
        Anshum Gupta added a comment -

        Seems like this broke the build (precommit failure @ svn:eol-style).
        I've fixed it locally, just running precommit before I commit this fix.

        Show
        Anshum Gupta added a comment - Seems like this broke the build (precommit failure @ svn:eol-style). I've fixed it locally, just running precommit before I commit this fix.
        Hide
        ASF subversion and git services added a comment -

        Commit 1697811 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1697811 ]

        SOLR-7972: Fix svn:eol-style for encoding.vm

        Show
        ASF subversion and git services added a comment - Commit 1697811 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1697811 ] SOLR-7972 : Fix svn:eol-style for encoding.vm
        Hide
        ASF subversion and git services added a comment -

        Commit 1697812 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1697812 ]

        SOLR-7972: Fix svn:eol-style for encoding.vm (merge from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1697812 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1697812 ] SOLR-7972 : Fix svn:eol-style for encoding.vm (merge from trunk)
        Hide
        Anshum Gupta added a comment -

        Committed the fix.

        Show
        Anshum Gupta added a comment - Committed the fix.
        Hide
        Anshum Gupta added a comment -

        Sorry for the email notification spam but I see the fix version on this as 5.3.1 ,among others, but I don't see a commit to the lucene_solr_5_3 branch. Erik Hatcher did you miss that one accidentally? I'm removing the 5.3.1 fix version for now until you comment/fix.

        Show
        Anshum Gupta added a comment - Sorry for the email notification spam but I see the fix version on this as 5.3.1 ,among others, but I don't see a commit to the lucene_solr_5_3 branch. Erik Hatcher did you miss that one accidentally? I'm removing the 5.3.1 fix version for now until you comment/fix.
        Hide
        Erik Hatcher added a comment -

        Anshum Gupta thanks! I just woke up to the build errors and was fixing it when I noticed you beat me to it. And thanks for removing the 5.3.1 fix version - if we do make such a release this can be merged over there but maybe no need yet.

        Show
        Erik Hatcher added a comment - Anshum Gupta thanks! I just woke up to the build errors and was fixing it when I noticed you beat me to it. And thanks for removing the 5.3.1 fix version - if we do make such a release this can be merged over there but maybe no need yet.
        Hide
        ASF subversion and git services added a comment -

        Commit 1701886 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_3'
        [ https://svn.apache.org/r1701886 ]

        SOLR-7972, SOLR-7929, SOLR-7978: merge fixes to 5.3 branch for 5.3.1 release

        Show
        ASF subversion and git services added a comment - Commit 1701886 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1701886 ] SOLR-7972 , SOLR-7929 , SOLR-7978 : merge fixes to 5.3 branch for 5.3.1 release

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development