Solr
  1. Solr
  2. SOLR-7854

Remove ZkStateReader.updateClusterState(false)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.2.1
    • Fix Version/s: 5.3, 6.0
    • Component/s: SolrCloud
    • Labels:

      Description

      `updateClusterState(false)` as far as I can tell has zero callers. It's super pointless anyway, because `updateClusterState(true)` is being used mostly from test code and in places where someone is trying to force a reload from ZK (for whatever reason). There's no point in asking for a deferred update when ZkStateReader is already going to keep itself in sync anyway.

        Activity

        Hide
        Mark Miller added a comment -

        updateClusterState(false) use to be used a lot to prevent silly rapid updates faster than was useful. Long ago, someone removed it's use but never cleaned it up fully.

        Show
        Mark Miller added a comment - updateClusterState(false) use to be used a lot to prevent silly rapid updates faster than was useful. Long ago, someone removed it's use but never cleaned it up fully.
        Hide
        Scott Blum added a comment -

        Simple patch against trunk.
        (Would like to backport also)

        Show
        Scott Blum added a comment - Simple patch against trunk. (Would like to backport also)
        Hide
        ASF subversion and git services added a comment -

        Commit 1693681 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1693681 ]

        SOLR-7854: Remove unused ZkStateReader.updateClusterState(false) method

        Show
        ASF subversion and git services added a comment - Commit 1693681 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1693681 ] SOLR-7854 : Remove unused ZkStateReader.updateClusterState(false) method
        Hide
        ASF subversion and git services added a comment -

        Commit 1693707 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1693707 ]

        SOLR-7854: Remove unused ZkStateReader.updateClusterState(false) method

        Show
        ASF subversion and git services added a comment - Commit 1693707 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1693707 ] SOLR-7854 : Remove unused ZkStateReader.updateClusterState(false) method
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Scott!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Scott!
        Hide
        Scott Blum added a comment -

        ty for landing Shalin

        Show
        Scott Blum added a comment - ty for landing Shalin
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Scott Blum
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development