Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None

      Description

      github pull request with proposed small changes/optimisations to follow

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/181

        SOLR-7751: tweak QueryComponent.process

        for https://issues.apache.org/jira/i#browse/SOLR-7751

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-query-component-tweaks

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/181.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #181


        commit c156bacb85b1535efa208a6a08c1c8d92c8c3349
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2015-07-01T17:45:56Z

        SOLR-????: tweak QueryComponent.process

        summary of changes:

        • for ShardParams.IDS requests the timeAllowed params check is not needed and so can be deferred to after the ShardParams.IDS code block
        • added local variables to avoid duplicate getSearcher/getSchema/getField calls

        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/181 SOLR-7751 : tweak QueryComponent.process for https://issues.apache.org/jira/i#browse/SOLR-7751 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-query-component-tweaks Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/181.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #181 commit c156bacb85b1535efa208a6a08c1c8d92c8c3349 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2015-07-01T17:45:56Z SOLR-????: tweak QueryComponent.process summary of changes: for ShardParams.IDS requests the timeAllowed params check is not needed and so can be deferred to after the ShardParams.IDS code block added local variables to avoid duplicate getSearcher/getSchema/getField calls
        Hide
        ASF subversion and git services added a comment -

        Commit 1689652 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1689652 ]

        SOLR-7751: Minor optimizations to QueryComponent.process

        Show
        ASF subversion and git services added a comment - Commit 1689652 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1689652 ] SOLR-7751 : Minor optimizations to QueryComponent.process
        Hide
        ASF subversion and git services added a comment -

        Commit 1689653 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1689653 ]

        SOLR-7751: Minor optimizations to QueryComponent.process

        Show
        ASF subversion and git services added a comment - Commit 1689653 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1689653 ] SOLR-7751 : Minor optimizations to QueryComponent.process
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release
        Hide
        ASF GitHub Bot added a comment -

        Github user cpoerschke closed the pull request at:

        https://github.com/apache/lucene-solr/pull/181

        Show
        ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/181

          People

          • Assignee:
            Ramkumar Aiyengar
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development