[SOLR-7705] CoreAdminHandler Unload no longer handles null core name.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.10, 5.0, 5.1, 5.2
• Fix Version/s: 5.3, 6.0
• Component/s: clients - java
• Labels: easyfix

Environment

Windows 8 and Windows Server 2012 R2

• Assignee: Shalin Shekhar Mangar
• Reporter: John Call
• Created: 19/Jun/15 16:47
• Updated: 09/May/16 18:53
• Resolved: 12/Jul/15 05:31

Description

Pre 4.10 If a null core name was passed in it would be handled as a bad request with error message "No such core exists [ null ]". From 4.10 onwards an unload call goes to CoreContainer unload where the first action taken is removing the core from coreInitFailures which throws when given null and instead of returning the expected BadRequest "Cannot unload non-existent core [null]" it returns InternalServerError "java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.replaceNode(Unknown Source)
at java.util.concurrent.ConcurrentHashMap.remove(Unknown Source)
at org.apache.solr.core.CoreContainer.unload(CoreContainer.java:661)..."

This was found due to mixing up query parameter "name" used in create vs "core" in unload. As a result this is easily reproducible with http://localhost:8983/solr/admin/cores?action=UNLOAD&name=core0