Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The code for streaming DocList is replicated in many response writers . Refactor it into a single place and re-use everywhere

      1. SOLR-7662_5X.patch
        34 kB
        Noble Paul
      2. SOLR-7662_5X.patch
        32 kB
        Noble Paul
      3. SOLR-7662.patch
        14 kB
        Noble Paul

        Activity

        Hide
        Noble Paul added a comment -

        As I'm doing this refactoring I notice a few discrepancies in the way the javabin and Text response writers

        • javabin returns the primitive types of the fields while the text based writers return a IndexableField/StorableFIeld depends on whether you are in branch 5x or trunk
        • javabin returns only the requested fields while text response writers get all the fields

        This was fine till transformers were introduced. Transformers have to be conscious of these differences and should be coded accordingly . We need to standardize these .

        Show
        Noble Paul added a comment - As I'm doing this refactoring I notice a few discrepancies in the way the javabin and Text response writers javabin returns the primitive types of the fields while the text based writers return a IndexableField/StorableFIeld depends on whether you are in branch 5x or trunk javabin returns only the requested fields while text response writers get all the fields This was fine till transformers were introduced. Transformers have to be conscious of these differences and should be coded accordingly . We need to standardize these .
        Hide
        Noble Paul added a comment -

        all tests pass

        Show
        Noble Paul added a comment - all tests pass
        Hide
        ASF subversion and git services added a comment -

        Commit 1685764 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685764 ]

        SOLR-7662: Refactored response writing to consolidate the logic in one place

        Show
        ASF subversion and git services added a comment - Commit 1685764 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685764 ] SOLR-7662 : Refactored response writing to consolidate the logic in one place
        Hide
        ASF subversion and git services added a comment -

        Commit 1685767 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685767 ]

        SOLR-7662: removed unused method

        Show
        ASF subversion and git services added a comment - Commit 1685767 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685767 ] SOLR-7662 : removed unused method
        Hide
        ASF subversion and git services added a comment -

        Commit 1685812 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685812 ]

        SOLR-7662: failed test GetByIdTest

        Show
        ASF subversion and git services added a comment - Commit 1685812 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685812 ] SOLR-7662 : failed test GetByIdTest
        Hide
        ASF subversion and git services added a comment -

        Commit 1685823 from Noble Paul in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1685823 ]

        SOLR-7662: failed test

        Show
        ASF subversion and git services added a comment - Commit 1685823 from Noble Paul in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1685823 ] SOLR-7662 : failed test
        Hide
        ASF subversion and git services added a comment -

        Commit 1685856 from Noble Paul in branch 'dev/trunk'
        [ https://svn.apache.org/r1685856 ]

        SOLR-7662: Refactored response writing to consolidate the logic in one place

        Show
        ASF subversion and git services added a comment - Commit 1685856 from Noble Paul in branch 'dev/trunk' [ https://svn.apache.org/r1685856 ] SOLR-7662 : Refactored response writing to consolidate the logic in one place
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development