Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7623

Return the ability to override request dispatcher functions

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.2
    • Fix Version/s: 5.2.1, 5.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      In SOLR-7484, the request dispatcher was refactored in a way that made it impossible to override basic functions. In particular we need to be able to override:

       protected void execute(SolrQueryResponse rsp)
      

      and

      protected void sendError(int code, String message) throws IOException {
      

        Issue Links

          Activity

          Hide
          ryantxu Ryan McKinley added a comment -

          Before 5.2, we could override execute/sendError directly in the SolrDispatchFilter

          At 5.2, it is not possible

          After 5.2, you can override SolrDispatchFilter#getHttpSolrCall with an implementation that overrides execute/sendError

          See:
          https://svn.apache.org/r1683024 (branch_5x)
          https://svn.apache.org/r1683025 (trunk)

          Show
          ryantxu Ryan McKinley added a comment - Before 5.2, we could override execute/sendError directly in the SolrDispatchFilter At 5.2, it is not possible After 5.2, you can override SolrDispatchFilter#getHttpSolrCall with an implementation that overrides execute/sendError See: https://svn.apache.org/r1683024 (branch_5x) https://svn.apache.org/r1683025 (trunk)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683034 from Ryan McKinley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1683034 ]

          SOLR-7623: add CHANGES.txt entry

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683034 from Ryan McKinley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1683034 ] SOLR-7623 : add CHANGES.txt entry
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683035 from Ryan McKinley in branch 'dev/trunk'
          [ https://svn.apache.org/r1683035 ]

          Merged revision(s) 1683034 from lucene/dev/branches/branch_5x:
          SOLR-7623: add CHANGES.txt entry
          ........

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683035 from Ryan McKinley in branch 'dev/trunk' [ https://svn.apache.org/r1683035 ] Merged revision(s) 1683034 from lucene/dev/branches/branch_5x: SOLR-7623 : add CHANGES.txt entry ........
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683036 from Ryan McKinley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1683036 ]

          SOLR-7623: make the constructor public

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683036 from Ryan McKinley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1683036 ] SOLR-7623 : make the constructor public
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683037 from Ryan McKinley in branch 'dev/trunk'
          [ https://svn.apache.org/r1683037 ]

          Merged revision(s) 1683036 from lucene/dev/branches/branch_5x:
          SOLR-7623: make the constructor public
          ........

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683037 from Ryan McKinley in branch 'dev/trunk' [ https://svn.apache.org/r1683037 ] Merged revision(s) 1683036 from lucene/dev/branches/branch_5x: SOLR-7623 : make the constructor public ........
          Hide
          anshumg Anshum Gupta added a comment -

          Thanks for fixing this Ryan McKinley.

          Show
          anshumg Anshum Gupta added a comment - Thanks for fixing this Ryan McKinley .
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683050 from Ryan McKinley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1683050 ]

          SOLR-7623: make private variables protected so you can actually override

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683050 from Ryan McKinley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1683050 ] SOLR-7623 : make private variables protected so you can actually override
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1683051 from Ryan McKinley in branch 'dev/trunk'
          [ https://svn.apache.org/r1683051 ]

          Merged revision(s) 1683050 from lucene/dev/branches/branch_5x:
          SOLR-7623: make private variables protected so you can actually override
          ........

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1683051 from Ryan McKinley in branch 'dev/trunk' [ https://svn.apache.org/r1683051 ] Merged revision(s) 1683050 from lucene/dev/branches/branch_5x: SOLR-7623 : make private variables protected so you can actually override ........
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          If we actually want to keep supporting this over time we probably want some comments or a test to that effect.

          Show
          markrmiller@gmail.com Mark Miller added a comment - If we actually want to keep supporting this over time we probably want some comments or a test to that effect.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Reopening for 5.2.1 backport

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Reopening for 5.2.1 backport
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1684265 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2'
          [ https://svn.apache.org/r1684265 ]

          SOLR-7623: backporting for Solr 5.2.1

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1684265 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1684265 ] SOLR-7623 : backporting for Solr 5.2.1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1684268 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2'
          [ https://svn.apache.org/r1684268 ]

          SOLR-7623: backporting for Solr 5.2.1 (commit was actually a part of SOLR-7274)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1684268 from Anshum Gupta in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1684268 ] SOLR-7623 : backporting for Solr 5.2.1 (commit was actually a part of SOLR-7274 )
          Hide
          anshumg Anshum Gupta added a comment -

          I'll try and add tests for this before the RC for 5.2.1 is cut, if I'm unable to do so, I'll create another issue for adding tests.

          Show
          anshumg Anshum Gupta added a comment - I'll try and add tests for this before the RC for 5.2.1 is cut, if I'm unable to do so, I'll create another issue for adding tests.
          Hide
          ryantxu Ryan McKinley added a comment -

          Here is the beginning of a test – but not yet working. I'll try to get some time to look at it more, but won't have any for another couple weeks

          Show
          ryantxu Ryan McKinley added a comment - Here is the beginning of a test – but not yet working. I'll try to get some time to look at it more, but won't have any for another couple weeks
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1684302 from Anshum Gupta in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1684302 ]

          SOLR-7623: Fixing the CHANGES.txt entry in branch_5x. Moving it to 5.2.1 section from 5.3

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1684302 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1684302 ] SOLR-7623 : Fixing the CHANGES.txt entry in branch_5x. Moving it to 5.2.1 section from 5.3
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          I opened SOLR-7690 for the tests. Marking this as resolved because 5.2.1 has been released with this fix.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - I opened SOLR-7690 for the tests. Marking this as resolved because 5.2.1 has been released with this fix.

            People

            • Assignee:
              ryantxu Ryan McKinley
              Reporter:
              ryantxu Ryan McKinley
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development