Solr
  1. Solr
  2. SOLR-7610

Improve and demonstrate VelocityResponseWriter's $resource localization tool

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2
    • Fix Version/s: 5.2
    • Component/s: None
    • Labels:
      None

      Description

      Improvement: fix $resource.locale, which currently reports the base Solr server locale rather than the one set by v.locale

      Demonstrate: Localize example/file's /browse

      1. SOLR-7610.patch
        28 kB
        Esther Quansah
      2. SOLR-7610.patch
        19 kB
        Erik Hatcher
      3. SOLR-7610.patch
        24 kB
        Esther Quansah
      4. SOLR-7610-example_files_config.patch
        3 kB
        Erik Hatcher
      5. SOLR-7610-resourcetool.patch
        1 kB
        Erik Hatcher

        Activity

        Hide
        Erik Hatcher added a comment -

        Here's a patch that fixes $resource.locale to report the current setting properly

        Show
        Erik Hatcher added a comment - Here's a patch that fixes $resource.locale to report the current setting properly
        Hide
        Erik Hatcher added a comment -

        This patch moves resources.properties to example/files/browse-resources/velocity (new directory to be created) and has solrconfig.xml point to that directory.

        Show
        Erik Hatcher added a comment - This patch moves resources.properties to example/files/browse-resources/velocity (new directory to be created) and has solrconfig.xml point to that directory.
        Hide
        ASF subversion and git services added a comment -

        Commit 1682900 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1682900 ]

        SOLR-7610: Fix VelocityResponseWriter's .locale to accurately report locale in use

        Show
        ASF subversion and git services added a comment - Commit 1682900 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1682900 ] SOLR-7610 : Fix VelocityResponseWriter's .locale to accurately report locale in use
        Hide
        ASF subversion and git services added a comment -

        Commit 1682901 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1682901 ]

        SOLR-7610: Move CHANGES.txt entry to bug fix section

        Show
        ASF subversion and git services added a comment - Commit 1682901 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1682901 ] SOLR-7610 : Move CHANGES.txt entry to bug fix section
        Hide
        ASF subversion and git services added a comment -

        Commit 1682902 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1682902 ]

        SOLR-7610: Fix VelocityResponseWriter's .locale to accurately report locale in use (merged from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1682902 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1682902 ] SOLR-7610 : Fix VelocityResponseWriter's .locale to accurately report locale in use (merged from trunk)
        Hide
        Esther Quansah added a comment -

        Adjusted url for locale, new local param that points to v.locale, localized content tabs and static text for French, English, German

        Show
        Esther Quansah added a comment - Adjusted url for locale, new local param that points to v.locale, localized content tabs and static text for French, English, German
        Hide
        Erik Hatcher added a comment - - edited

        Thanks Esther Quansah! I've tinkered with things a bit (diff my patch and your patch to see specifically) including: changed globe icon to gear simply because it was already built-in and doesn't refer to a remote resource, some minor resource properties tweaks, and additionally I added, tangentially, the extracting of e-mail addresses and URLs from file content into email_ss and url_ss fields (try &facet.field=email_ss&facet.field=url_ss).

        Maybe we add back a globe icon, but something small, free for us to use legally, and built-in. Note: binary files need to be added to JIRA tickets separately from .patch files.

        Show
        Erik Hatcher added a comment - - edited Thanks Esther Quansah ! I've tinkered with things a bit (diff my patch and your patch to see specifically) including: changed globe icon to gear simply because it was already built-in and doesn't refer to a remote resource, some minor resource properties tweaks, and additionally I added, tangentially, the extracting of e-mail addresses and URLs from file content into email_ss and url_ss fields (try &facet.field=email_ss&facet.field=url_ss). Maybe we add back a globe icon, but something small, free for us to use legally, and built-in. Note: binary files need to be added to JIRA tickets separately from .patch files.
        Hide
        Esther Quansah added a comment -

        New globe icon and international icons! Updated README with image licenses.

        Show
        Esther Quansah added a comment - New globe icon and international icons! Updated README with image licenses.
        Hide
        ASF subversion and git services added a comment -

        Commit 1683150 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_2'
        [ https://svn.apache.org/r1683150 ]

        SOLR-7610: Fix VelocityResponseWriter's .locale to accurately report locale in use (merged from branch_5x)

        Show
        ASF subversion and git services added a comment - Commit 1683150 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1683150 ] SOLR-7610 : Fix VelocityResponseWriter's .locale to accurately report locale in use (merged from branch_5x)
        Hide
        ASF subversion and git services added a comment -

        Commit 1683178 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1683178 ]

        SOLR-7610: move CHANGES.txt entry - got this in for 5.2

        Show
        ASF subversion and git services added a comment - Commit 1683178 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1683178 ] SOLR-7610 : move CHANGES.txt entry - got this in for 5.2
        Hide
        ASF subversion and git services added a comment -

        Commit 1683179 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1683179 ]

        SOLR-7610: move CHANGES.txt entry - got this in for 5.2

        Show
        ASF subversion and git services added a comment - Commit 1683179 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1683179 ] SOLR-7610 : move CHANGES.txt entry - got this in for 5.2
        Hide
        ASF subversion and git services added a comment -

        Commit 1683181 from Erik Hatcher in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1683181 ]

        SOLR-7610: fix example/files README and other minor improvements/localization

        Show
        ASF subversion and git services added a comment - Commit 1683181 from Erik Hatcher in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1683181 ] SOLR-7610 : fix example/files README and other minor improvements/localization
        Hide
        ASF subversion and git services added a comment -

        Commit 1683184 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_2'
        [ https://svn.apache.org/r1683184 ]

        SOLR-7610: fix example/files README and other minor improvements/localization

        Show
        ASF subversion and git services added a comment - Commit 1683184 from Erik Hatcher in branch 'dev/branches/lucene_solr_5_2' [ https://svn.apache.org/r1683184 ] SOLR-7610 : fix example/files README and other minor improvements/localization
        Hide
        ASF subversion and git services added a comment -

        Commit 1683187 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1683187 ]

        SOLR-7610: fix example/files README and other minor improvements/localization

        Show
        ASF subversion and git services added a comment - Commit 1683187 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1683187 ] SOLR-7610 : fix example/files README and other minor improvements/localization
        Hide
        Erik Hatcher added a comment -

        yay, got this into 5.2 - README fixes and such

        Show
        Erik Hatcher added a comment - yay, got this into 5.2 - README fixes and such
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development