Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7508

SolrParams.toMultiMap() does not handle arrays

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0, 5.1
    • Fix Version/s: None
    • Component/s: SolrJ
    • Labels:

      Description

      Following JUnit test to show what I mean:

      ModifiableSolrParams params = new ModifiableSolrParams();
      String[] paramValues = new String[] { "title:junit", "author:john" };
      String paramName = "fq";
      params.add(paramName, paramValues);
      NamedList<Object> namedList = params.toNamedList();
      assertEquals("parameter values are not equal", paramValues, namedList.get(paramName));
      Map<String, String[]> multiMap = SolrParams.toMultiMap(namedList);
      assertEquals("Expected " + paramValues.length + " values", paramValues.length, multiMap.get(paramName).length);
      

      The first assertEquals() will run fine, while the last one triggers the error. Suddenly the length of the array is "1" and it's value of fq is like [Ljava.lang.String;@6f09c9c0. Looking into the code I see that the toMultiMap() method does not even look for arrays.

        Attachments

        1. SOLRJ-7508.patch
          0.8 kB
          Thomas Scheffler

          Activity

            People

            • Assignee:
              noble.paul Noble Paul
              Reporter:
              thosch Thomas Scheffler
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: