Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7470

jvm/filesystem dependent failures in SolrCloudExampleTest.testLoadDocsIntoGettingStartedCollection -- directory traversal order dependency

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.2, 6.0
    • None
    • None

    Description

      SolrCloudExampleTest.testLoadDocsIntoGettingStartedCollection currently fails 100% reliably on my laptop, regardless of seed with a root cause of...

         [junit4]   2> 35968 T60 N:127.0.0.1:57372_ C:gettingstarted S:shard1 R:core_node1 c:gettingstarted_shard1_replica2 C15 oasc.SolrException.log ERROR org.apache.solr.common.SolrException: ERROR: [doc=VS1GB400C3] Error adding field 'price'='74.99' msg=For input string: "74.99"
         [junit4]   2> 		at org.apache.solr.update.DocumentBuilder.toDocument(DocumentBuilder.java:178)
         [junit4]   2> 		at org.apache.solr.update.AddUpdateCommand.getLuceneDocument(AddUpdateCommand.java:79)
         [junit4]   2> 		at org.apache.solr.update.DirectUpdateHandler2.addDoc0(DirectUpdateHandler2.java:237)
         [junit4]   2> 		at org.apache.solr.update.DirectUpdateHandler2.addDoc(DirectUpdateHandler2.java:163)
         [junit4]   2> 		at org.apache.solr.update.processor.RunUpdateProcessor.processAdd(RunUpdateProcessorFactory.java:69)
      

      This test uses "data_driven_schema_configs" and indexes all of the *.xml files in "example/exampledocs".

      Two factors seem to be contributing to the the reason this fails consistently for me (but not for jenkins or anyone else i've seen complain)...

      1. The File.listFiles(FileFilter) method is used to iterate over the files
      2. The "mem.xml" file has an integer price value: <field name="price">185</field>

      listFiles is documented that "There is no guarantee that the name strings in the resulting array will appear in any specific order" and evidently with my filesystem + JVM they come back in a consistent order everytime, which just so happens to put mem.xml in front of any other file that also has a "price" field.

      Attachments

        1. SOLR-7470.patch
          3 kB
          Chris M. Hostetter

        Issue Links

          Activity

            People

              hossman Chris M. Hostetter
              hossman Chris M. Hostetter
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: