[SOLR-7327] DefaultSolrHighlighter should lazily create a FVH FieldQuery.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Component/s: highlighter
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 30/Mar/15 14:06
• Updated: 10/Nov/16 21:21
• Resolved: 10/Nov/16 21:21

Description

DefaultSolrHighlighter switches between both the standard/default/classic Highlighter and the FastVectorHighlighter, depending on parameters and field options. In doHighlighting(), it loops over the docs, then loops over the highlighted fields, then decides to use one highlighter or the other. Outside of the doc loop it creates a FastVectorHighlighter instance (cheap) and a related FieldQuery object that may or may not be cheap. fvh.getFieldQuery takes an IndexReader instance and it will be used for certain queries like MultiTermQuery (e.g. wildcards). We shouldn't be doing this unless we know we'll actually need it – it should be lazily constructed.

Issue Links

• is related to: SOLR-6692 hl.maxAnalyzedChars should apply cumulatively on a multi-valued field