Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7325

Change Slice state into enum

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.2, 6.0
    • SolrJ
    • None

    Description

      Slice state is currently interacted with as a string. It is IMO not trivial to understand which values it can be compared to, in part because the Replica and Slice states are located in different classes, some repeating same constant names and values.

      Also, it's not very clear when does a Slice get into which state and what does that mean.

      I think if it's an enum, and documented briefly in the code, it would help interacting with it through code. I don't mind if we include more extensive documentation in the reference guide / wiki and refer people there for more details.

      Attachments

        1. SOLR-7325.patch
          4 kB
          Shai Erera
        2. SOLR-7325.patch
          36 kB
          Shai Erera
        3. SOLR-7325.patch
          44 kB
          Shai Erera

        Activity

          People

            shaie Shai Erera
            shaie Shai Erera
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: