Solr
  1. Solr
  2. SOLR-7290

Change schemaless _text and copyField

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      schemaless configs should remove copyField to _text
      or at least change _text name.
      http://markmail.org/message/v6djadk5azx6k4gv

      This default led to bad indexing performance.

      1. SOLR-7290.patch
        4 kB
        Steve Rowe
      2. SOLR-7290.patch
        3 kB
        Steve Rowe

        Issue Links

          Activity

          Hide
          Steve Rowe added a comment -

          The _text field and the copyField directive targetting it were added in SOLR-6471.

          Show
          Steve Rowe added a comment - The _text field and the copyField directive targetting it were added in SOLR-6471 .
          Hide
          Yonik Seeley added a comment -

          Anyone have thoughts on changing
          "_text" to either "_text_" or just "text"

          Show
          Yonik Seeley added a comment - Anyone have thoughts on changing "_text" to either "_text_" or just "text"
          Hide
          Erick Erickson added a comment -

          Personally I'd slightly prefer "text" to just "text", although I can argue either way. "text" is clearly a reserved field, OTOH "text" is something we already use as the df.

          "_text" is a distant third IMO since it's too easy to confuse with a dynamic field.

          FWIW,
          Erick

          Show
          Erick Erickson added a comment - Personally I'd slightly prefer " text " to just "text", although I can argue either way. " text " is clearly a reserved field, OTOH "text" is something we already use as the df. "_text" is a distant third IMO since it's too easy to confuse with a dynamic field. FWIW, Erick
          Hide
          Erik Hatcher added a comment -

          I prefer _text_.

          Show
          Erik Hatcher added a comment - I prefer _text_.
          Hide
          Varun Thacker added a comment -

          I prefer _text_.

          +1

          Show
          Varun Thacker added a comment - I prefer _text_. +1
          Hide
          Steve Rowe added a comment -

          +1 for _text_ - any objections to changing this in 5.1? If we're going to change it, I think we should do it sooner rather than later.

          Show
          Steve Rowe added a comment - +1 for _text_ - any objections to changing this in 5.1? If we're going to change it, I think we should do it sooner rather than later.
          Hide
          Yonik Seeley added a comment -

          +1 for text - any objections to changing this in 5.1? If we're going to change it, I think we should do it sooner rather than later.

          +1

          Show
          Yonik Seeley added a comment - +1 for text - any objections to changing this in 5.1? If we're going to change it, I think we should do it sooner rather than later. +1
          Hide
          Erick Erickson added a comment -

          +1 for changingin 5.1

          Show
          Erick Erickson added a comment - +1 for changingin 5.1
          Hide
          Steve Rowe added a comment -

          Patch.

          I'm running tests now.

          Show
          Steve Rowe added a comment - Patch. I'm running tests now.
          Hide
          Steve Rowe added a comment -

          Added note to "Upgrading from 5.0" section in CHANGES.txt

          Show
          Steve Rowe added a comment - Added note to "Upgrading from 5.0" section in CHANGES.txt
          Hide
          Steve Rowe added a comment -

          Tests passed.

          Committing shortly.

          Show
          Steve Rowe added a comment - Tests passed. Committing shortly.
          Hide
          ASF subversion and git services added a comment -

          Commit 1671234 from Steve Rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1671234 ]

          SOLR-7290: Rename catchall text field in data_driven_schema_configs to _text

          Show
          ASF subversion and git services added a comment - Commit 1671234 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1671234 ] SOLR-7290 : Rename catchall text field in data_driven_schema_configs to _text
          Hide
          ASF subversion and git services added a comment -

          Commit 1671235 from Steve Rowe in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1671235 ]

          SOLR-7290: Rename catchall text field in data_driven_schema_configs to _text (merged trunk r1671234)

          Show
          ASF subversion and git services added a comment - Commit 1671235 from Steve Rowe in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1671235 ] SOLR-7290 : Rename catchall text field in data_driven_schema_configs to _text (merged trunk r1671234)
          Hide
          ASF subversion and git services added a comment -

          Commit 1671236 from Steve Rowe in branch 'dev/branches/lucene_solr_5_1'
          [ https://svn.apache.org/r1671236 ]

          SOLR-7290: Rename catchall text field in data_driven_schema_configs to _text (merged trunk r1671234)

          Show
          ASF subversion and git services added a comment - Commit 1671236 from Steve Rowe in branch 'dev/branches/lucene_solr_5_1' [ https://svn.apache.org/r1671236 ] SOLR-7290 : Rename catchall text field in data_driven_schema_configs to _text (merged trunk r1671234)
          Hide
          Steve Rowe added a comment -

          Committed the renaming patch to trunk, branch_5x and lucene_solr_5_1.

          Note that this leaves the copyField behavior intact.

          I'll resolve this issue - if people want to continue discussing the copyField behavior, please create another issue.

          Show
          Steve Rowe added a comment - Committed the renaming patch to trunk, branch_5x and lucene_solr_5_1. Note that this leaves the copyField behavior intact. I'll resolve this issue - if people want to continue discussing the copyField behavior, please create another issue.
          Hide
          Timothy Potter added a comment -

          Bulk close after 5.1 release

          Show
          Timothy Potter added a comment - Bulk close after 5.1 release

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Mike Murphy
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development