Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7262

Registering / changing request handlers not thread safe

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.1
    • None
    • None

    Description

      Here's part of the javadoc for RequestHandlers.register()

         * This call is thread safe.
         * 
         * @return the previous handler at the given path or null
         */
        public SolrRequestHandler register( String handlerName, SolrRequestHandler handler ) {
      

      But looking at the changes from SOLR-7073, this is clearly not the case (it's no longer thread safe). Was this thread safety removed on purpose or was it accidental?

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            yseeley@gmail.com Yonik Seeley
            yseeley@gmail.com Yonik Seeley
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment