Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-720

Persistence does not write the expected XML

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      CoreContainer.persist() writes the core container properties at the 'wrong' place in the XML.
      A Solr webapp with a solr.xml stating persistent='true' may fail to restart if the file is written.
      They should be written under /solr - not /solr/cores aka before (not after):

        /** Write the cores configuration through a writer.*/
        void persist(Writer writer) throws IOException {
      ...
          writer.write("<cores adminPath='");
      ...
      
      1. SOLR-720.patch
        0.9 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Committed revision 688411.

          Thanks Henri !

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 688411. Thanks Henri !
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Patch to fix this.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Patch to fix this.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Ah! I should be more careful. I shall fix this.

          Thanks for catching this Henri.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Ah! I should be more careful. I shall fix this. Thanks for catching this Henri.

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              henrib Henri Biestro
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development