[SOLR-7115] UpdateLog can miss closing transaction log objects.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.4, 7.0
• Assignee: Yonik Seeley
• Reporter: Mark Miller
• Created: 14/Feb/15 23:24
• Updated: 14/Apr/17 14:12
• Resolved: 14/Apr/17 14:12

Description

I've seen this happen on YourKit and in various tests - especially since adding resource release tracking to the log objects. Now I've got a test that catches it in SOLR-7113.

It seems that in precommit, if prevTlog is not null, we need to close it because we are going to overwrite prevTlog with a new log.

Issue Links

• breaks: SOLR-9712 Saner default for maxWarmingSearchers
• relates to: SOLR-7113 Multiple calls to UpdateLog#init is not thread safe with respect to the HDFS FileSystem client object usage.
• relates to: SOLR-9116 Race condition causing occasional SolrIndexSearcher leak when SolrCore is reloaded
• relates to: SOLR-9076 Update to Hadoop 2.7.2