Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-7115

UpdateLog can miss closing transaction log objects.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 6.4, 7.0
    • None
    • None

    Description

      I've seen this happen on YourKit and in various tests - especially since adding resource release tracking to the log objects. Now I've got a test that catches it in SOLR-7113.

      It seems that in precommit, if prevTlog is not null, we need to close it because we are going to overwrite prevTlog with a new log.

      Attachments

        1. tests-failures-7115.txt
          73 kB
          Mikhail Khludnev
        2. SOLR-7115.patch
          8 kB
          Mikhail Khludnev
        3. SOLR-7115.patch
          5 kB
          Mikhail Khludnev
        4. SOLR-7115-LargeVolumeEmbeddedTest-fail.txt
          104 kB
          Mikhail Khludnev

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            yseeley@gmail.com Yonik Seeley
            markrmiller@gmail.com Mark Miller
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment