Solr
  1. Solr
  2. SOLR-7032

Clean up test remnants of old-style solr.xml

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1, 6.0
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      After Alan's heroic work with pulling out support of old-style solr.xml, there are still a few mentions in some of the test code and a couple of places where solr.xml is synthesized inline found just by grepping on
      "<cores".

      The code itself will throw an error when processing solr.xml if there are <cores> or <core> tags, so there's no reason to try to get this patch in to 5.0.

      1. SOLR-7032.patch
        18 kB
        Erick Erickson
      2. SOLR-7032.patch
        18 kB
        Erick Erickson

        Activity

        Hide
        Erick Erickson added a comment -

        Preliminary patch, all tests pass but I need to look this over a bit. The bits I want to check over are some map-reduce changes and the test files for old-solr-example and solr-multicore.xml that I removed.

        Show
        Erick Erickson added a comment - Preliminary patch, all tests pass but I need to look this over a bit. The bits I want to check over are some map-reduce changes and the test files for old-solr-example and solr-multicore.xml that I removed.
        Hide
        Alan Woodward added a comment -

        Bah, I thought I'd expunged all trace of this. They're not tripping any test failures, which suggests that they're completely unused and we can safely rip them out.

        It looks as though there's going to be a respin for 5.0, so I think it's worth getting this in.

        Show
        Alan Woodward added a comment - Bah, I thought I'd expunged all trace of this. They're not tripping any test failures, which suggests that they're completely unused and we can safely rip them out. It looks as though there's going to be a respin for 5.0, so I think it's worth getting this in.
        Hide
        Erick Erickson added a comment -

        ba: Bah, I thought I'd expunged all trace of this

        You did a boatload of work, this is entirely minor.....

        bq: They're not tripping any test failures, which suggests that they're completely unused and we can safely rip them out

        Yeah, which leads me to some questions about our test harness, why does the mr test that synthesizes solr.xml code not die in 5.0? Probably doesn't go down the same parsing path maybe? Same with the multicore bits I took out.

        bq: It looks as though there's going to be a respin for 5.0, so I think it's worth getting this in.

        Easy enough to do, but leaving them in 5.0 isn't doing any harm either. I don't have strong feelings one way or the other, it'd be nice not to have even these remnants in to make 5.0 clean, but is that aesthetic worth the (minimal I admit) risk? Anyone else want to weigh in?

        Show
        Erick Erickson added a comment - ba: Bah, I thought I'd expunged all trace of this You did a boatload of work, this is entirely minor..... bq: They're not tripping any test failures, which suggests that they're completely unused and we can safely rip them out Yeah, which leads me to some questions about our test harness, why does the mr test that synthesizes solr.xml code not die in 5.0? Probably doesn't go down the same parsing path maybe? Same with the multicore bits I took out. bq: It looks as though there's going to be a respin for 5.0, so I think it's worth getting this in. Easy enough to do, but leaving them in 5.0 isn't doing any harm either. I don't have strong feelings one way or the other, it'd be nice not to have even these remnants in to make 5.0 clean, but is that aesthetic worth the (minimal I admit) risk? Anyone else want to weigh in?
        Hide
        Erick Erickson added a comment -

        Final patch with CHANGES.txt entry.

        Show
        Erick Erickson added a comment - Final patch with CHANGES.txt entry.
        Hide
        ASF subversion and git services added a comment -

        Commit 1660790 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1660790 ]

        SOLR-7032: Clean up tests remnanat of old-style solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1660790 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1660790 ] SOLR-7032 : Clean up tests remnanat of old-style solr.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1660796 from Erick Erickson in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1660796 ]

        SOLR-7032: Clean up tests remnanat of old-style solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1660796 from Erick Erickson in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1660796 ] SOLR-7032 : Clean up tests remnanat of old-style solr.xml
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Erick Erickson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development