ba: Bah, I thought I'd expunged all trace of this
You did a boatload of work, this is entirely minor.....
bq: They're not tripping any test failures, which suggests that they're completely unused and we can safely rip them out
Yeah, which leads me to some questions about our test harness, why does the mr test that synthesizes solr.xml code not die in 5.0? Probably doesn't go down the same parsing path maybe? Same with the multicore bits I took out.
bq: It looks as though there's going to be a respin for 5.0, so I think it's worth getting this in.
Easy enough to do, but leaving them in 5.0 isn't doing any harm either. I don't have strong feelings one way or the other, it'd be nice not to have even these remnants in to make 5.0 clean, but is that aesthetic worth the (minimal I admit) risk? Anyone else want to weigh in?