Solr
  1. Solr
  2. SOLR-692

Migrate StAX to latest released version

        Details

        • Type: Task Task
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 1.3
        • Fix Version/s: 1.3
        • Component/s: clients - java
        • Labels:
          None

          Description

          The current StAX jar in the lib folder is an un-released version – 1.2.0-dev. This should be replaced by a stable release. The latest released version available on the central maven repository is 1.2.0 as seen at http://repo1.maven.org/maven2/stax/stax/

          This issue shall track the migration to a stable released version of StAX and related problems, if any.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            Ryan, the stax-1.2.0-dev.jar in the lib folder was added with the SolrJ (SOLR-20) commit on 15th June 2007. The 1.2.0 release available on maven repository is dated 4th January, 2007. Any special fixes/features due to which this particular dev version was used?

            I'm anyway going to change it locally and run all tests.

            Show
            Shalin Shekhar Mangar added a comment - Ryan, the stax-1.2.0-dev.jar in the lib folder was added with the SolrJ ( SOLR-20 ) commit on 15th June 2007. The 1.2.0 release available on maven repository is dated 4th January, 2007. Any special fixes/features due to which this particular dev version was used? I'm anyway going to change it locally and run all tests.
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            All tests pass with stax-1.2.0.jar

            Is it worth upgrading the stax-api from 1.0 to 1.0.1 too while we are on this?

            Show
            Shalin Shekhar Mangar added a comment - All tests pass with stax-1.2.0.jar Is it worth upgrading the stax-api from 1.0 to 1.0.1 too while we are on this?
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            All tests pass with stax-1.2.0.jar and stax-api-1.0.1.jar

            Is there any objection to changing these jars? Just a "svn remove old-jar" and "svn add new-jar" should suffice. Any special care which should be taken while doing this migration?

            Show
            Shalin Shekhar Mangar added a comment - All tests pass with stax-1.2.0.jar and stax-api-1.0.1.jar Is there any objection to changing these jars? Just a "svn remove old-jar" and "svn add new-jar" should suffice. Any special care which should be taken while doing this migration?
            Hide
            Permalink
            Ryan McKinley added a comment -

            nothing special I know of for solrj... I just copied from what we were already using.

            +1 for committing soon. Releasing with a standard version is obviously better then a dev build.

            Show
            Ryan McKinley added a comment - nothing special I know of for solrj... I just copied from what we were already using. +1 for committing soon. Releasing with a standard version is obviously better then a dev build.
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            Committed revision 685449.

            Show
            Shalin Shekhar Mangar added a comment - Committed revision 685449.

              People

              • Assignee:
                Shalin Shekhar Mangar
                Reporter:
                Shalin Shekhar Mangar
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development