Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.10.2, 5.0, 6.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Some of the example collections include scripts.conf in the conf directory. It is not used by anything in the distribution and is somehow left over from the Solr 1.x legacy days.

      It should be possible to safe delete it to avoid confusing users trying to understand what different files actually do.

      1. SOLR-6876.patch
        7 kB
        Erick Erickson

        Activity

        Hide
        Alexandre Rafalovitch added a comment -

        Fix - delete the following files:

        solr/example/example-DIH/solr/db/conf/scripts.conf
        solr/example/example-DIH/solr/mail/conf/scripts.conf
        solr/example/example-DIH/solr/rss/conf/scripts.conf
        solr/example/example-DIH/solr/solr/conf/scripts.conf
        solr/server/solr/configsets/sample_techproducts_configs/conf/scripts.conf

        ant test passes with the files deleted.

        Show
        Alexandre Rafalovitch added a comment - Fix - delete the following files: solr/example/example-DIH/solr/db/conf/scripts.conf solr/example/example-DIH/solr/mail/conf/scripts.conf solr/example/example-DIH/solr/rss/conf/scripts.conf solr/example/example-DIH/solr/solr/conf/scripts.conf solr/server/solr/configsets/sample_techproducts_configs/conf/scripts.conf ant test passes with the files deleted.
        Hide
        Erick Erickson added a comment -

        Do we know for sure whether these should go away? I'm unfamiliar
        with the ins and outs of DIH that I wan to check...

        Show
        Erick Erickson added a comment - Do we know for sure whether these should go away? I'm unfamiliar with the ins and outs of DIH that I wan to check...
        Hide
        Alexandre Rafalovitch added a comment -

        They are not referenced by name by anything in the distribution. I did a grep search for them. And removing them passes all the test. And seem to be related to the ancient Solr 1.x replication that's also not shipped any more (as per discussion on the dev mailing list and the only place mentioned in the sources).

        I could not figure out any other way to confirm their usefulness.

        Show
        Alexandre Rafalovitch added a comment - They are not referenced by name by anything in the distribution. I did a grep search for them. And removing them passes all the test. And seem to be related to the ancient Solr 1.x replication that's also not shipped any more (as per discussion on the dev mailing list and the only place mentioned in the sources). I could not figure out any other way to confirm their usefulness.
        Hide
        Erick Erickson added a comment -

        Right, mostly I'm giving people with looonng memories a chance to chime in before I commit it
        in case there's some web page out there that references them, there's no guarantee that tests
        cover it.

        I fully expect you're right, I'll probably commit this tomorrow unless
        1> people with long memories tell us that any of them are used
        or
        2> people familiar with the code tell us that they're unnecessary....

        Thanks!

        Show
        Erick Erickson added a comment - Right, mostly I'm giving people with looonng memories a chance to chime in before I commit it in case there's some web page out there that references them, there's no guarantee that tests cover it. I fully expect you're right, I'll probably commit this tomorrow unless 1> people with long memories tell us that any of them are used or 2> people familiar with the code tell us that they're unnecessary.... Thanks!
        Hide
        Koji Sekiguchi added a comment -

        I think scripts.conf file is not for DIH, but it is for replication scripts. sold/scripts/scripts-util includes scripts.conf and scripts-util is included from many scripts in solr/scripts directory.

        I don't know Solr users in the world still use shell script based replication, except me.

        Show
        Koji Sekiguchi added a comment - I think scripts.conf file is not for DIH, but it is for replication scripts. sold/scripts/scripts-util includes scripts.conf and scripts-util is included from many scripts in solr/scripts directory. I don't know Solr users in the world still use shell script based replication, except me.
        Hide
        Erick Erickson added a comment -

        I think I'm going to close this one "won't fix". As Koji points out, these support SnapPuller, which still ships with trunk.

        So they're still potentially useful. Although the note on the Wiki that these haven't been actively maintained
        since the 1.4 days kind of makes you wonder....

        I'll give it a day or so for people to render different opinions, but otherwise I think they should stay.

        Show
        Erick Erickson added a comment - I think I'm going to close this one "won't fix". As Koji points out, these support SnapPuller, which still ships with trunk. So they're still potentially useful. Although the note on the Wiki that these haven't been actively maintained since the 1.4 days kind of makes you wonder.... I'll give it a day or so for people to render different opinions, but otherwise I think they should stay.
        Hide
        Alexandre Rafalovitch added a comment -

        I do not believe they ship with 5.0. I can't find them in the distribution. Only in the source.

        Or are these build-time artifacts? In which case I am not sure what the one in the configsets is doing given that it represents the latest core, not an actual one.

        Show
        Alexandre Rafalovitch added a comment - I do not believe they ship with 5.0. I can't find them in the distribution. Only in the source. Or are these build-time artifacts? In which case I am not sure what the one in the configsets is doing given that it represents the latest core, not an actual one.
        Hide
        Erick Erickson added a comment -

        Well, the "SnapPuller" class is still there in trunk. Therefore I assume that it's
        at least possible to use these configs (or a variant).

        The big warning on the Wiki is that the scripts aren't actively maintained, not
        that they're obsolete.

        OTOH, if people who know more about this than me think obfuscating
        snappuller is A Good Thing we can remove them, I'm kind of waiting for
        folks to either tell me I'm waaaaay off base or that it's OK to take them
        out.

        Show
        Erick Erickson added a comment - Well, the "SnapPuller" class is still there in trunk. Therefore I assume that it's at least possible to use these configs (or a variant). The big warning on the Wiki is that the scripts aren't actively maintained, not that they're obsolete. OTOH, if people who know more about this than me think obfuscating snappuller is A Good Thing we can remove them, I'm kind of waiting for folks to either tell me I'm waaaaay off base or that it's OK to take them out.
        Hide
        Shalin Shekhar Mangar added a comment -

        Well, the "SnapPuller" class is still there in trunk. Therefore I assume that it's at least possible to use these configs (or a variant).

        The SnapPuller class in the code if for the Java based replication. It has no relation to the replication scripts or the scripts.conf files.

        I don't think we should keep shipping these scripts or these scripts.conf files. We can archive it somewhere on the wiki and nuke them from source.

        Show
        Shalin Shekhar Mangar added a comment - Well, the "SnapPuller" class is still there in trunk. Therefore I assume that it's at least possible to use these configs (or a variant). The SnapPuller class in the code if for the Java based replication. It has no relation to the replication scripts or the scripts.conf files. I don't think we should keep shipping these scripts or these scripts.conf files. We can archive it somewhere on the wiki and nuke them from source.
        Hide
        Erick Erickson added a comment -

        Like I said,

        "I'm kind of waiting for folks to either tell me I'm waaaaay off base or that it's OK to take them out."

        OK, they'll be gone today/tomorrow.

        Thanks!

        Show
        Erick Erickson added a comment - Like I said, "I'm kind of waiting for folks to either tell me I'm waaaaay off base or that it's OK to take them out." OK, they'll be gone today/tomorrow. Thanks!
        Hide
        Erick Erickson added a comment -

        Patch with entry in CHANGES.txt

        Show
        Erick Erickson added a comment - Patch with entry in CHANGES.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1648246 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1648246 ]

        SOLR-6876: Remove unused legacy scripts.conf

        Show
        ASF subversion and git services added a comment - Commit 1648246 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1648246 ] SOLR-6876 : Remove unused legacy scripts.conf
        Hide
        ASF subversion and git services added a comment -

        Commit 1648252 from Erick Erickson in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1648252 ]

        SOLR-6876: Remove unused legacy scripts.conf

        Show
        ASF subversion and git services added a comment - Commit 1648252 from Erick Erickson in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1648252 ] SOLR-6876 : Remove unused legacy scripts.conf
        Hide
        Erick Erickson added a comment -

        Thanks Alexandre!

        Show
        Erick Erickson added a comment - Thanks Alexandre!
        Show
        Varun Thacker added a comment - Hi Erick Erickson , This change requires updating this ref guide page right? https://cwiki.apache.org/confluence/display/solr/Index+Replication#IndexReplication-TheSnapshotandDistributionProcess
        Hide
        Alexandre Rafalovitch added a comment -

        I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped.

        Show
        Alexandre Rafalovitch added a comment - I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped.
        Hide
        Hoss Man added a comment -

        I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped.

        pruned now.

        Show
        Hoss Man added a comment - I think that whole section refers to the stuff that no longer ships with Solr. I don't know as of when the shipping it stopped. pruned now.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Alexandre Rafalovitch
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development