[SOLR-6724] HttpServer maxRetries attributes seems like not being used as expected

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.10.2
• Component/s: clients - java

Environment

OS X 10.9.5
Java 1.7.0_60

• Assignee: Unassigned
• Reporter: Márcio Furlani Carmona
• Created: 10/Nov/14 23:26
• Updated: 09/Mar/15 01:09

Description

Looks like maxRetries is being misused in the org.apache.solr.client.solrj.impl.HttpSolrServer.createMethod(SolrRequest) instead of being used in the executeMethod(HttpRequestBase,ResponseParser).

In the current implementation the maxRetries is used in a loop that only instantiates the HttpRequestBase but it doesn't effectively make any HTTP request. Also the retries are made even in a successful instantiation of the HttpRequestBase as there's no break too.
I notice there's also a catch for NoHttpResponseException but as no HTTP request is made I guess it will never happen.

Issue Links

• is duplicated by: SOLR-7203 NoHttpResponseException handling in HttpSolrClient is wrong