Solr
  1. Solr
  2. SOLR-6697

bin/solr start script should allow setting SOLR_OPTS in solr.in.*

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.2
    • Fix Version/s: 5.0, 6.0
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      It is possible to set ADDITIONAL_CMD_OPTS in e.g. solr.in.sh, but it should be documented by comments.

      Also, if you have set this in solr.in.sh, and then start with -a "some params", these will overwrite the ADDITIONAL_CMD_OPTS set in the solr.in file. More logical would be for them to be appended.

      1. SOLR-6697.patch
        3 kB
        Jan Høydahl
      2. SOLR-6697.patch
        4 kB
        Jan Høydahl

        Activity

        Hide
        Jan Høydahl added a comment -

        First patch. Tested on OSX. This patch adds a commented section to solr.in.* setting the env var SOLR_OPTS, which is then picked up in the start scripts and added to the start options. It will not conflict with options added with the -a argument.

        Show
        Jan Høydahl added a comment - First patch. Tested on OSX. This patch adds a commented section to solr.in.* setting the env var SOLR_OPTS , which is then picked up in the start scripts and added to the start options. It will not conflict with options added with the -a argument.
        Hide
        Jan Høydahl added a comment -

        Moved changes entry to "Other changes" section since this is not really a bug fix. Question is if we should add features to solr/bin in 4.10.x releases at all like we did in 4.10.2. I'd say yes for now...

        Show
        Jan Høydahl added a comment - Moved changes entry to "Other changes" section since this is not really a bug fix. Question is if we should add features to solr/bin in 4.10.x releases at all like we did in 4.10.2. I'd say yes for now...
        Hide
        ASF subversion and git services added a comment -

        Commit 1638423 from janhoy@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1638423 ]

        SOLR-6697: bin/solr start scripts allow setting SOLR_OPTS in solr.in.*

        Show
        ASF subversion and git services added a comment - Commit 1638423 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1638423 ] SOLR-6697 : bin/solr start scripts allow setting SOLR_OPTS in solr.in.*
        Hide
        ASF subversion and git services added a comment -

        Commit 1638428 from janhoy@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1638428 ]

        SOLR-6697: bin/solr start scripts allow setting SOLR_OPTS in solr.in.* (backport)

        Show
        ASF subversion and git services added a comment - Commit 1638428 from janhoy@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1638428 ] SOLR-6697 : bin/solr start scripts allow setting SOLR_OPTS in solr.in.* (backport)
        Hide
        Jan Høydahl added a comment -

        Committed. Will not backport to 4.x since this is not a bug.

        Show
        Jan Høydahl added a comment - Committed. Will not backport to 4.x since this is not a bug.
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development