Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6680

DefaultSolrHighlighter can sometimes avoid CachingTokenFilter

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • highlighter
    • None

    Description

      The DefaultSolrHighlighter (the most accurate one) is a bit over-eager to wrap the token stream in a CachingTokenFilter when hl.usePhraseHighlighter=true. This wastes memory, and it interferes with other optimizations – LUCENE-6034. Furthermore, the internal TermOffsetsTokenStream (used when TermVectors are used with this) wasn't properly delegating reset().

      Attachments

        1. SOLR-6680.patch
          10 kB
          David Smiley
        2. SOLR-6680.patch
          16 kB
          David Smiley
        3. SOLR-6680_Solr_Highligher,_part_2,_OffsetWindowTokenFilter.patch
          1 kB
          David Smiley

        Issue Links

          requires

          Improvement - An improvement or enhancement to an existing feature or task. LUCENE-6033 Add CachingTokenFilter.isCached and switch LinkedList to ArrayList

          • Major - Major loss of function.
          • Closed

          Activity

            People

              dsmiley David Smiley
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: